Skip to content

python: Fix instability of Pyright/BasedPyright code completions#37850

Merged
osiewicz merged 2 commits intomainfrom
fix-pyright-jumpy-jumpy-complete-complete
Sep 9, 2025
Merged

python: Fix instability of Pyright/BasedPyright code completions#37850
osiewicz merged 2 commits intomainfrom
fix-pyright-jumpy-jumpy-complete-complete

Conversation

@osiewicz
Copy link
Member

@osiewicz osiewicz commented Sep 9, 2025

Pyright sets different sortText based on whether a given completion item was recently resolved. This probably lines up with VSCode's way of resolving items, but it's a no-no for us, as it makes completions unstable.

Closes #9983

Release Notes:

  • python: Fixed code completions having arbitrary order when using Pyright/basedpyright

Pyright sets different `sortText` based on whether a given completion item was recently resolved. This probably lines up with VSCode's way of resolving items,
but it's a no-no for us, as it makes completions unstable.
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 9, 2025
@maxdeviant maxdeviant changed the title python: Fix instability of PyRight/BasedPyRight code completions python: Fix instability of Pyright/BasedPyright code completions Sep 9, 2025
@osiewicz osiewicz enabled auto-merge (squash) September 9, 2025 15:20
@osiewicz osiewicz merged commit 2e7607c into main Sep 9, 2025
21 checks passed
@osiewicz osiewicz deleted the fix-pyright-jumpy-jumpy-complete-complete branch September 9, 2025 15:34
tidely pushed a commit to tidely/zed that referenced this pull request Sep 10, 2025
…-industries#37850)

Pyright sets different `sortText` based on whether a given completion
item was recently resolved. This probably lines up with VSCode's way of
resolving items, but it's a no-no for us, as it makes completions
unstable.

Closes zed-industries#9983

Release Notes:

- python: Fixed code completions having arbitrary order when using
Pyright/basedpyright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Python autocompletion suggestions are not stable

1 participant