Revert "gpui: Do not render ligatures between different styled text runs (#37175)#37382
Merged
maxdeviant merged 1 commit intomainfrom Sep 2, 2025
Merged
Revert "gpui: Do not render ligatures between different styled text runs (#37175)#37382maxdeviant merged 1 commit intomainfrom
maxdeviant merged 1 commit intomainfrom
Conversation
tidely
pushed a commit
to tidely/zed
that referenced
this pull request
Sep 10, 2025
…uns (zed-industries#37175) (zed-industries#37382) This reverts commit 62083fe. We're reverting this as it causes layout shift when typing/selecting with ligatures: https://github.com/user-attachments/assets/80b78909-62f5-404f-8cca-3535c5594ceb Release Notes: - Reverted zed-industries#37175
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 62083fe.
We're reverting this as it causes layout shift when typing/selecting with ligatures:
Screen.Recording.2025-09-02.at.11.37.42.AM.mov
Release Notes: