Skip to content

Fix issue where renaming a file would not update imports in related files if they are not open#36681

Merged
smitbarmase merged 16 commits intomainfrom
will-rename-mutli-buffer
Aug 21, 2025
Merged

Fix issue where renaming a file would not update imports in related files if they are not open#36681
smitbarmase merged 16 commits intomainfrom
will-rename-mutli-buffer

Conversation

@smitbarmase
Copy link
Member

@smitbarmase smitbarmase commented Aug 21, 2025

Closes #34445

Now we open a multi-buffer consisting of buffers that have updated, renamed file imports.

Only local is handled, for now.

Release Notes:

  • Fixed an issue where renaming a file would not update imports in related files if they are not already open.

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Aug 21, 2025
@smitbarmase smitbarmase changed the title Fix issue where renaming a file would not update imports in related files Fix issue where renaming a file would not update imports in related files if they are not open Aug 21, 2025
@smitbarmase smitbarmase merged commit 697a39c into main Aug 21, 2025
24 checks passed
@smitbarmase smitbarmase deleted the will-rename-mutli-buffer branch August 21, 2025 14:49
orual pushed a commit to orual/zed that referenced this pull request Aug 23, 2025
…iles if they are not open (zed-industries#36681)

Closes zed-industries#34445

Now we open a multi-buffer consisting of buffers that have updated,
renamed file imports.

Only local is handled, for now.

Release Notes:

- Fixed an issue where renaming a file would not update imports in
related files if they are not already open.
tidely pushed a commit to tidely/zed that referenced this pull request Sep 10, 2025
…iles if they are not open (zed-industries#36681)

Closes zed-industries#34445

Now we open a multi-buffer consisting of buffers that have updated,
renamed file imports.

Only local is handled, for now.

Release Notes:

- Fixed an issue where renaming a file would not update imports in
related files if they are not already open.
FrGoIs pushed a commit to FrGoIs/zed that referenced this pull request Sep 29, 2025
…iles if they are not open (zed-industries#36681)

Closes zed-industries#34445

Now we open a multi-buffer consisting of buffers that have updated,
renamed file imports.

Only local is handled, for now.

Release Notes:

- Fixed an issue where renaming a file would not update imports in
related files if they are not already open.
gaauwe added a commit that referenced this pull request Dec 17, 2025
Fixes an issue where we would update the imports after a file rename in
TypeScript, but those changes wouldn't surface anywhere until those
buffers were manually opened
(#35930 (comment)).
In #36681 we already added
support for opening a multibuffer with edits, but vtsls has a different
flow for renames.

Release Notes:

- Files with updated imports now open in a multibuffer when renaming or
moving TypeScript or JavaScript files
HactarCE pushed a commit that referenced this pull request Dec 17, 2025
Fixes an issue where we would update the imports after a file rename in
TypeScript, but those changes wouldn't surface anywhere until those
buffers were manually opened
(#35930 (comment)).
In #36681 we already added
support for opening a multibuffer with edits, but vtsls has a different
flow for renames.

Release Notes:

- Files with updated imports now open in a multibuffer when renaming or
moving TypeScript or JavaScript files
rtfeldman pushed a commit that referenced this pull request Jan 5, 2026
Fixes an issue where we would update the imports after a file rename in
TypeScript, but those changes wouldn't surface anywhere until those
buffers were manually opened
(#35930 (comment)).
In #36681 we already added
support for opening a multibuffer with edits, but vtsls has a different
flow for renames.

Release Notes:

- Files with updated imports now open in a multibuffer when renaming or
moving TypeScript or JavaScript files
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
…tries#45110)

Fixes an issue where we would update the imports after a file rename in
TypeScript, but those changes wouldn't surface anywhere until those
buffers were manually opened
(zed-industries#35930 (comment)).
In zed-industries#36681 we already added
support for opening a multibuffer with edits, but vtsls has a different
flow for renames.

Release Notes:

- Files with updated imports now open in a multibuffer when renaming or
moving TypeScript or JavaScript files
LivioGama pushed a commit to LivioGama/zed that referenced this pull request Jan 20, 2026
…tries#45110)

Fixes an issue where we would update the imports after a file rename in
TypeScript, but those changes wouldn't surface anywhere until those
buffers were manually opened
(zed-industries#35930 (comment)).
In zed-industries#36681 we already added
support for opening a multibuffer with edits, but vtsls has a different
flow for renames.

Release Notes:

- Files with updated imports now open in a multibuffer when renaming or
moving TypeScript or JavaScript files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

documentChanges after workspace/willRenameFiles has no effect

1 participant