task: Don't show VSCode worktree tasks when Zed ones exist#32590
Merged
task: Don't show VSCode worktree tasks when Zed ones exist#32590
Conversation
moktamd
added a commit
to moktamd/zed
that referenced
this pull request
Mar 18, 2026
Moves the .vscode task filtering from the modal presentation layer down into the inventory's worktree_scenarios(), so all consumers get the correct behavior. Also filters previously spawned .vscode tasks from the used-tasks list when .zed tasks are present. The previous fix in zed-industries#32590 only filtered .vscode tasks in the task picker modal, missing other code paths and the used-tasks list.
SomeoneToIgnore
pushed a commit
that referenced
this pull request
Mar 24, 2026
Fixes #51733 The previous fix in #32590 only filtered `.vscode` tasks at the modal presentation layer, so they still appeared in other code paths and in the used-tasks list. This moves the filtering into `worktree_scenarios()` in the task inventory, so all consumers see the correct behavior. Changes: - `InventoryFor::worktree_scenarios()` now skips `.vscode` entries when `.zed` entries exist for the same worktree - `used_and_current_resolved_tasks()` filters previously spawned `.vscode` tasks from the used-tasks list - Removes the now-redundant `.vscode` filter from the task picker modal Release Notes: - Fixed .vscode/tasks.json still being used when .zed/tasks.json is present Co-authored-by: moktamd <moktamd@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23110
Similar to #32589, we may eventually want to merge instead of making these lists mutually exclusive.
Release Notes: