Scroll to follow expanding part of editor::SelectLargerSyntaxNode#27295
Merged
marcospb19 merged 6 commits intomainfrom Mar 22, 2025
Merged
Scroll to follow expanding part of editor::SelectLargerSyntaxNode#27295marcospb19 merged 6 commits intomainfrom
editor::SelectLargerSyntaxNode#27295marcospb19 merged 6 commits intomainfrom
Conversation
this refac will allow me to reuse the function in another piece of code too
P1n3appl3
added a commit
that referenced
this pull request
Apr 7, 2025
With #27295, the cursor would center upon running `SelectLargerSyntaxNode`. This was done to provide more context when making large selections, but when making small selections (such as a single parameter in an argument list) it was confusing that the scroll position jumped. This change makes that behavior slightly more conservative: now when the selection is small enough to fit on the screen scrolling will only occur to keep the cursor position on the screen (including respecting `vertical_scroll_margin`). Release Notes: - N/A Co-authored-by: João Marcos <marcospb19@hotmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the selection grows both ways, the new code prioritizes the top part instead of bottom one, this is usually more helpful considering that most programming language grammars tend to define tokens right before large delimited blocks, and rarely after (because humans and parsers read from top to bottom).
Also, revert selection when convenient, so you have more control over what you're selecting, looking at the selection
headis commonly more convenient than at thetail.Also, if you scroll away
editor::SelectSmallerSyntaxNodewill do a better job at restoring you to the position you were before.Release Notes:
editor::SelectLargerSyntaxNodefor better visibility.