Add editor::AcceptNextLineEditPrediction to accept next line suggestion only#25274
Closed
aevsai wants to merge 3 commits intozed-industries:mainfrom
Closed
Add editor::AcceptNextLineEditPrediction to accept next line suggestion only#25274aevsai wants to merge 3 commits intozed-industries:mainfrom
editor::AcceptNextLineEditPrediction to accept next line suggestion only#25274aevsai wants to merge 3 commits intozed-industries:mainfrom
Conversation
editor::AcceptNextLineEditPrediction to accept next line suggestion only
This comment was marked as resolved.
This comment was marked as resolved.
Contributor
Author
|
|
9b036ef to
23e505c
Compare
Contributor
|
I'm going to go ahead and close this as stale given that there hasn't been any activity in 4months and there are merge conflicts. My apologies that we didn't get a chance to review this in a timely fashion. Please free to address the merge conflicts and reopen a clean PR and we'll try to do better next time. |
pull bot
pushed a commit
to FrancoStino/zed
that referenced
this pull request
Dec 15, 2025
Closes [zed-industries#20574](zed-industries#20574) Release Notes: - Replaced editor action editor::AcceptPartialEditPrediction with editor::AcceptNextLineEditPrediction and editor::AcceptNextWordEditPrediction Tested manually on windows, attaching screen cap. https://github.com/user-attachments/assets/fea04499-fd16-4b7d-a6aa-3661bb85cf4f Updated existing test for accepting word prediction in copilot - it is already marked as flaky, not sure what to do about it and I'm not really confident creating new one without a working example. Added migration of keymaps and new defaults for windows, linux, macos in defaults and in cursor. This should alleviate [zed-industries#21645](zed-industries#21645) I used some work done in stale PR zed-industries#25274, hopefully this one makes it through! --------- Co-authored-by: Agus Zubiaga <agus@zed.dev>
CherryWorm
pushed a commit
to CherryWorm/zed
that referenced
this pull request
Dec 16, 2025
Closes [zed-industries#20574](zed-industries#20574) Release Notes: - Replaced editor action editor::AcceptPartialEditPrediction with editor::AcceptNextLineEditPrediction and editor::AcceptNextWordEditPrediction Tested manually on windows, attaching screen cap. https://github.com/user-attachments/assets/fea04499-fd16-4b7d-a6aa-3661bb85cf4f Updated existing test for accepting word prediction in copilot - it is already marked as flaky, not sure what to do about it and I'm not really confident creating new one without a working example. Added migration of keymaps and new defaults for windows, linux, macos in defaults and in cursor. This should alleviate [zed-industries#21645](zed-industries#21645) I used some work done in stale PR zed-industries#25274, hopefully this one makes it through! --------- Co-authored-by: Agus Zubiaga <agus@zed.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20574
Release Notes:
editor::AcceptNextLineEditPredictioneditor::AcceptPartialEditPredictionrenamed toeditor::AcceptNextWordEditPredictionChecklist:
Screen.Recording.2025-02-20.at.10.19.01.PM.mov