gpui: Fix text hover & active style#24723
Merged
mikayla-maki merged 14 commits intozed-industries:mainfrom Apr 10, 2025
Merged
Conversation
fd42ddd to
1e16283
Compare
90aa6d6 to
7d19c45
Compare
mikayla-maki
requested changes
Apr 10, 2025
mikayla-maki
approved these changes
Apr 10, 2025
mikayla-maki
added a commit
that referenced
this pull request
Apr 11, 2025
This reverts commit ffdf725.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes:
Fix this long-standing issue so that we can support Link hover colors.
And renamed
text_layoutexample totext_style.I spent some time studying the process of this text style change and found it a bit complicated.
At first, I thought there was a problem with refine and it was not passed properly. After changing it, I found that it was not the problem.
Then I found that it was because
TextRunhad already stored thecolor,background,underline,strikethroughin TextRun in therequest_layoutstage. They area calculate at therequest_layoutstage, but request_layout stage there was nohitbox, so the hover state was not obtained.CleanShot.2025-03-15.at.19.11.52.mp4