Skip to content

Implement missing low_speed_timeout functionality#18310

Closed
13W wants to merge 2 commits intozed-industries:v0.155.xfrom
13W:ollama-low_speed_timeout
Closed

Implement missing low_speed_timeout functionality#18310
13W wants to merge 2 commits intozed-industries:v0.155.xfrom
13W:ollama-low_speed_timeout

Conversation

@13W
Copy link
Copy Markdown

@13W 13W commented Sep 24, 2024

Release Notes:

  • Fixed usage of low_speed_timeout_in_seconds configuration parameter that was ignored in ollama stream_chat_completion function

@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Sep 24, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @13W on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

Signed-off-by: Vladimir Bulyga <zero@13w.me>
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Sep 24, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @13W on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@13W
Copy link
Copy Markdown
Author

13W commented Sep 24, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Sep 24, 2024
@cla-bot
Copy link
Copy Markdown

cla-bot bot commented Sep 24, 2024

The cla-bot has been summoned, and re-checked this pull request!

@ConradIrwin
Copy link
Copy Markdown
Member

Thanks for this! I'm in the process of reducing our dependence on isahc, so I've reimplemented this the new way at #18417

ConradIrwin added a commit that referenced this pull request Sep 27, 2024
Supercedes: #18310

Release Notes:

- Fixed `low_speed_timeout_in_seconds` for Ollama
@notpeter notpeter reopened this Sep 27, 2024
@notpeter notpeter changed the base branch from main to v0.155.x September 27, 2024 16:14
@notpeter notpeter closed this Sep 27, 2024
notpeter added a commit that referenced this pull request Sep 27, 2024
Supersedes: #18310
See also: #18304

This PR targets v0.155.x and is a hotfix for Preview.

Signed-off-by: Vladimir Bulyga <zero@13w.me>
Co-authored-by: Vladimir Bulyga <zero@13w.me>
noaccOS pushed a commit to noaccOS/zed that referenced this pull request Oct 19, 2024
Supercedes: zed-industries#18310

Release Notes:

- Fixed `low_speed_timeout_in_seconds` for Ollama
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants