project search: Stream search results to improve TTFB#16923
Merged
ConradIrwin merged 13 commits intomainfrom Aug 27, 2024
Merged
project search: Stream search results to improve TTFB#16923ConradIrwin merged 13 commits intomainfrom
ConradIrwin merged 13 commits intomainfrom
Conversation
Contributor
|
Overall, does it make much sense to do if we intend to track local project symbols in the near future? |
Do not merge. Need to check with Conrad. Co-authored-by: Antonio <antonio@zed.dev>
…ng-project-search
Co-Authored-By: Thorsten <thorsten@zed.dev>
dcbbf69 to
864024c
Compare
559d2d8 to
75d3e90
Compare
Contributor
This broke the ordering of the elements and now outline panel's order is different. |
mrnugget
added a commit
that referenced
this pull request
Aug 28, 2024
This fixes a little bug that has snuck in #16923 Release Notes: - N/A
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a prototype change to improve latency of local project searches. It refactors the matcher to keep paths "in-order" so that we don't need to wait for all matching files to display the first result.
On a test (searching for
<in zed.dev) it changes the time until first result from about 2s to about 50ms. The tail latency seems to increase slightly (from 5s to 7s) so we may want to do more tuning before hitting merge.Release Notes: