Conversation
This is required to compile successfully on macos versions <= 10.15 (catalina)
Member
|
Pretty weird error but excellent work figuring this out! ⚡ |
leizaf
pushed a commit
to leizaf/zed
that referenced
this pull request
Jan 26, 2024
Add haskell grammar
1 task
1 task
gabydd
pushed a commit
to gabydd/zed
that referenced
this pull request
Feb 26, 2024
linux/x11: Move from dedicated thread to fd source for event loop
1 task
1 task
1 task
d1y
pushed a commit
to d1y/zed1
that referenced
this pull request
Jun 25, 2024
Set up ground work for debugger config files
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
1 task
Closed
7 tasks
rtfeldman
added a commit
that referenced
this pull request
Feb 5, 2026
…uting - Fix #1: Both tools previously created filesystem tasks before authorization. GPUI tasks execute immediately when created, so the file operation could complete before the user even sees the permission prompt. - Now follows the delete_path_tool pattern: authorize.await runs first inside cx.spawn, then the filesystem task is created only after authorization succeeds. - Also fixes silent error discarding: removed let _ = on result.with_context()
rtfeldman
added a commit
that referenced
this pull request
Feb 5, 2026
- always_confirm_works_for_file_tools: verifies always_confirm patterns work for edit_file, delete_path, fetch (not just terminal), including precedence rules - test_create_directory_tool_deny_rule_blocks_creation: integration test for create_directory deny rules (was the only permission-using tool without one) - test_copy_path_tool_deny_by_user: verifies filesystem unchanged when user denies copy permission (validates race condition fix #1) - test_move_path_tool_deny_by_user: same for move_path tool
rtfeldman
added a commit
that referenced
this pull request
Feb 5, 2026
…ver match build_permission_options now splits the 'source -> destination' input_value and extracts the pattern from only the destination path for copy_path and move_path. This ensures saved Always Allow patterns actually match on subsequent invocations, since decide_permission_from_settings evaluates each path independently.
Caio-Ze
pushed a commit
to Caio-Ze/postprod-ide
that referenced
this pull request
Feb 14, 2026
V1 workspace-centric config: move config files to assets/config/, resolve tool paths with dir_has_content() to handle empty dirs, add package-protools build script. Bug fixes: - Empty directories no longer break tool path resolution (zed-industries#2) - Global hotkeys now call spawn_tool_entry() directly (zed-industries#5) - Hotkey config only re-registers when file content changes (zed-industries#1) - Remove redundant Plus (+) shortcut button (zed-industries#6) - Fix button text alignment to left (zed-industries#7) New feature: recent folders list below Pasta Ativa with click-to-switch and persistent storage in .pastas_recentes file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This seems to be required in order for the shaders to compile successfully on macOS versions <= 10.15 (Catalina). In these versions, when nested structs are used, we get errors like this:
for vertex function return types:
for fragment function inputs: