Merged
Conversation
This was referenced Jul 30, 2025
cole-miller
added a commit
to zed-industries/zed
that referenced
this pull request
Jul 31, 2025
…5344) Includes zed-industries/livekit-rust-sdks#7 Release Notes: - N/A
orual
pushed a commit
to orual/zed
that referenced
this pull request
Aug 23, 2025
…d-industries#35344) Includes zed-industries/livekit-rust-sdks#7 Release Notes: - N/A
kubkon
pushed a commit
that referenced
this pull request
Feb 25, 2026
* feat: expose DesktopCapturer
Implements screen sharing by exposing libwebrtc's
DesktopCapturer.
A few platform specific notes:
- macos:
* It is using screen capture kit and the system picker by
default. If the system picker is disabled then get_sources
returns an empty list when trying to capture a display. The
display native id needs to be acquired using different means
from the client.
- linux:
* With pipewire the only way to select window or display is via
the system picker.
* use pkg-config to find Linux libraries (#2)
* Support x11 dependencies
* Modify example to work on x11
* Address comments
* Properly guard sck options
* Address review comments
In particular:
- Adds support for the generic capturer.
- Exposes the desktop_capturer module only on macos, linux and
windows.
- Updates the example
* Update license
* Set callback on start
* Make the callback FnMut
* cpp formatting
* Allow disabling system picker in example
* Address review comments
* Remove reference to temporary
* Run screen-sharing example only on supported platforms
* cargo fmt
* Update build runner with DesktopCapturer deps on linux
* Update runner
* Update tests runner
* fix Android build (#7)
* screensharing example: remove rustls-native feature from livekit
This was breaking the Android builds.
* improve error handling for File::open
* webrtc-sys-build: skip parsing desktop_capture.ninja on Android
* webrtc-sys-build: bump prebuilt library to webrtc-0001d84-2
* Enable TLS features for the screenshare example
---------
Co-authored-by: Be <be.0@gmx.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that we download the webrtc release anew each time download_webrtc is called (from either the livekit-ffi build script or the webrtc-sys build script). This is another stab at fixing the build errors we've been seeing in Zed CI, or at least making them easier to understand.
Also reverts #6 since it seems the integrity of the downloaded zip was a red herring.