Authentication adjustments for JB integration#350
Authentication adjustments for JB integration#350benbrandt merged 8 commits intozed-industries:mainfrom
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @AlexandrSuhinin on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'. |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
@AlexandrSuhinin is there a RFD that discusses the gateway approach? Or is this a one-off solution specific to Claude Agent SDK? If so, what would be the best place for it to be documented then? |
benbrandt
left a comment
There was a problem hiding this comment.
Overall the approach seems pretty good, however, I feel like this gateway needs to be opt-in. I can also play around with it tomorrow
Only include the gateway auth method when the client advertises `auth._meta.gateway`. Add a temporary extended capabilities type until the ACP SDK schema includes `auth`, and update authorization tests to cover both offered and hidden gateway behavior.
|
@AlexandrSuhinin I pushed some changes
Basically it is more opt-in if we show the gateway, and also actually blocks usage if you are worried about it Let me know what you think cc @anna239 |
The authentication check introduced in zed-industries#350 blocks users who have previously logged into claude.ai but are now using alternative authentication methods (Foundry, Bedrock, or API key). This fix adds a check for alternative auth methods before throwing the "Authentication Required" error. Fixes zed-industries#376 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
@benbrandt Can we move the auth capability into _meta, since it's not part of the official protocol and would require a binary update of the library? I can open a new PR if you fine with these suggestion. |
|
@josevalim There is no official RFD for this yet; the plan is to check first if it works reasonably well. |
Updated authentication methods for IDEA compatibility and SDK compliance
New authentication type: gateway (url + custom headers)
Process argument to hide Claude Code authentication
https://platform.claude.com/docs/en/agent-sdk/overview