Skip to content

fix the permission issue with 'ziextract' when running it as root#557

Merged
vladdoster merged 5 commits intozdharma-continuum:mainfrom
yyykt:fix/ziextract-tar
Jan 2, 2024
Merged

fix the permission issue with 'ziextract' when running it as root#557
vladdoster merged 5 commits intozdharma-continuum:mainfrom
yyykt:fix/ziextract-tar

Conversation

@yyykt
Copy link
Contributor

@yyykt yyykt commented Aug 5, 2023

Description

Related Issue(s)

fixes #556

Motivation and Context

Usage examples

How Has This Been Tested?

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@pschmitt
Copy link
Member

pschmitt commented Aug 5, 2023

Is that flag available on all versions of tar? (Mac OS?)

@vladdoster
Copy link
Member

vladdoster commented Aug 14, 2023

@yyykt,

Could you share a way to reproduce the bug that this patch corrects? Additionally, can you explain what the flag does?

@vladdoster
Copy link
Member

Is that flag available on all versions of tar? (Mac OS?)

@pschmitt,

Yes, I can confirm macOS bsdtar has this flag.

@vladdoster vladdoster merged commit e2d477c into zdharma-continuum:main Jan 2, 2024
@vladdoster
Copy link
Member

@yyykt,

Sorry for the delay in merging this PR, but thank you lots for the fix!

github-actions bot pushed a commit that referenced this pull request Jan 18, 2024
# [3.13.0](v3.12.1...v3.13.0) (2024-01-18)

### Bug Fixes

* **ci:** remove duplicate gh-r  zunit job ([#623](#623)) ([70cefc0](70cefc0))
* debug logging logic and format ([#592](#592)) ([3c7e5be](3c7e5be))
* handle zinit --help ([#597](#597)) ([8cf9104](8cf9104))
* link ice check in .zinit-download-snippet function ([#608](#608)) ([358ef03](358ef03))
* pin dua gh-r test to v2.20.3 ([#605](#605)) ([0ba778a](0ba778a))
* silence unzip command in ziextract ([#614](#614)) ([71764bf](71764bf))
* tar permissions when `ziextract` ran as root user ([#557](#557)) ([e2d477c](e2d477c))
* update labeler config to v5 ([#604](#604)) ([794723c](794723c))

### Features

* configure, make, cmake, and build ices ([#613](#613)) ([#616](#616)) ([22e66db](22e66db))
* **delete:** fix unsetting plugin state & add `--debug` / `--quiet` flags ([#622](#622)) ([3f4b685](3f4b685))
* remove zpextract and use ziextract ([#611](#611)) ([2ccac85](2ccac85))
@github-actions
Copy link

🎉 This PR is included in version 3.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: compinit security warning when installing completions from gh-r as root user

3 participants