Skip to content

fix: Ignore .yaml and .py files when installing completions#528

Merged
pschmitt merged 7 commits intomainfrom
ignore-yaml-and-py-comps
Jun 15, 2023
Merged

fix: Ignore .yaml and .py files when installing completions#528
pschmitt merged 7 commits intomainfrom
ignore-yaml-and-py-comps

Conversation

@pschmitt
Copy link
Member

@pschmitt pschmitt commented Jun 4, 2023 •
edited
Loading

Description

  • fix: ignore .yaml and .py files when searching for completions
  • test: check for unwanted completions files

Related Issue(s)

Motivation and Context

Usage examples

zinit as"completions" \
	atclone"pipx install jc; jc --zsh-comp > _jc" \
    atdelete"pipx uninstall jc" \
for kellyjonbrazil/jc

How Has This Been Tested?

Without this, the above would install 13 completions (__init__.py etc)
With the patch only _jc gets installed, as expected.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • Documentation change
  • New feature (non-breaking change which adds functionality)

Checklist:

  • All new and existing tests passed.
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.

@pschmitt
Copy link
Member Author

pschmitt commented Jun 4, 2023 •
edited
Loading

urf, the gh-r test fail.
The ices zunit pass locally at least.

Edit: fixed in #530

@pschmitt pschmitt force-pushed the ignore-yaml-and-py-comps branch from 67c30ec to c374d23 Compare June 5, 2023 08:04
@vladdoster
Copy link
Member

vladdoster commented Jun 6, 2023

BTW, You can remove the python dependency

zinit for \
    from'gh-r' \
    no'compile' \
    lbin \
    atclone'$(pwd)/jc --zsh-comp > _jc' \
    as'completion' \
  @kellyjonbrazil/jc

@pschmitt
Copy link
Member Author

pschmitt commented Jun 6, 2023

BTW, You can remove the python dependency

zinit for \
    from'gh-r' \
    no'compile' \
    lbin \
    atclone'$(pwd)/jc --zsh-comp > _jc' \
    as'completion' \
  @kellyjonbrazil/jc

Yes that works too, sadly there's no arm64 build available.

@pschmitt pschmitt merged commit 113cfc4 into main Jun 15, 2023
@pschmitt pschmitt deleted the ignore-yaml-and-py-comps branch June 15, 2023 17:08
This was referenced Jun 16, 2023
Open
Closed
github-actions bot pushed a commit that referenced this pull request Aug 30, 2023
@vladdoster
release: v3.11.0 → v3.12.0
edf3061 
# [3.12.0](v3.11.0...v3.12.0) (2023-08-30)

### Bug Fixes

* build container for tagged releases ([f933dc0](f933dc0))
* gh-r linux regex & gh-r zunit tests ([#564](#564)) ([207ab9f](207ab9f))
* gh-r zunit tests ([#561](#561)) ([97b087e](97b087e))
* Ignore .yaml and .py files when installing completions ([#528](#528)) ([113cfc4](113cfc4))
* jq has moved from stedolan/jq to jqlang/jq ([#530](#530)) ([de85908](de85908))
* math expression in plugins command ([#559](#559)) ([68a6b42](68a6b42))
* pin fclones version to v0.31.0 ([497d519](497d519))
* quote parens so that they aren't used as globs ([#549](#549)) ([1375adf](1375adf))
* self-update check for updates ([#562](#562)) ([b456a2d](b456a2d))
* update gomi repo owner ([#568](#568)) ([19ca2dc](19ca2dc))

### Features

* build container with zsh 5.9 ([#525](#525)) ([238e843](238e843))
@github-actions
Copy link

github-actions bot commented Aug 30, 2023

🎉 This PR is included in version 3.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Porkepix Porkepix mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alichtman alichtman Awaiting requested review from alichtman alichtman is a code owner

@vladdoster vladdoster Awaiting requested review from vladdoster vladdoster is a code owner

Assignees

No one assigned

Labels

released tests zinit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pschmitt @vladdoster