Replace CSproutNotePlaintextEntry with SproutNoteEntry to match Sapling#4036
Merged
zkbot merged 1 commit intozcash:masterfrom Jun 6, 2019
Merged
Replace CSproutNotePlaintextEntry with SproutNoteEntry to match Sapling#4036zkbot merged 1 commit intozcash:masterfrom
zkbot merged 1 commit intozcash:masterfrom
Conversation
str4d
approved these changes
May 28, 2019
LarryRuane
approved these changes
Jun 5, 2019
Collaborator
LarryRuane
left a comment
There was a problem hiding this comment.
ACK, ran sprout_sapling_migration.py but no other testing.
Contributor
Author
|
@zkbot r+ |
Contributor
|
📌 Commit a630f50 has been approved by |
Contributor
zkbot
added a commit
that referenced
this pull request
Jun 5, 2019
Replace CSproutNotePlaintextEntry with SproutNoteEntry to match Sapling This refactoring makes the output of GetFilteredNotes safer to use, by setting the Sprout note at the point of decryption, where the corresponding address is already known, rather than having to recall it using the correct payment address.
Contributor
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactoring makes the output of GetFilteredNotes safer to use, by setting the Sprout note at the point of decryption, where the corresponding address is already known, rather than having to recall it using the correct payment address.