Skip to content

Release v2.0.1#3602

Merged
zkbot merged 4 commits intozcash:masterfrom
bitcartel:release-v2.0.1
Oct 14, 2018
Merged

Release v2.0.1#3602
zkbot merged 4 commits intozcash:masterfrom
bitcartel:release-v2.0.1

Conversation

@bitcartel
Copy link
Copy Markdown
Contributor

@bitcartel bitcartel commented Oct 14, 2018

No description provided.

@bitcartel
Copy link
Copy Markdown
Contributor Author

bitcartel commented Oct 14, 2018 •
edited
Loading

Note to reviewers:

  • Release height 411500 targets Monday 15th October (we prefer not to release on Friday and weekends)
  • Sanity-check protocol version! Also check Mainnet configuration in chainparams.cpp.
    • PROTOCOL_VERSION = 170007 (set in release v2.0.0 as the protocol version for Sapling consensus aware nodes)
    • MIN_PEER_PROTO_VERSION = 170002 (same as at launch, we can change this once Sapling has activated and all nodes < Sapling protocol version have been deprecated)

@bitcartel bitcartel added the C-release Category: This is an issue corresponding to the creation of a specific release. label Oct 14, 2018
@bitcartel bitcartel added this to the v2.0.1 milestone Oct 14, 2018
daira
daira approved these changes Oct 14, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK modulo the comments on release notes I made in another PR.

@bitcartel
Copy link
Copy Markdown
Contributor Author

bitcartel commented Oct 14, 2018

@daira Addressed your comments. I created an extra commit to update the release notes and ran the release script again before force pushing to this PR.

mdr0id
mdr0id approved these changes Oct 14, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@mdr0id mdr0id left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ebfull
Copy link
Copy Markdown
Contributor

ebfull commented Oct 14, 2018

@zkbot r+

@zkbot
Copy link
Copy Markdown
Contributor

zkbot commented Oct 14, 2018

📌 Commit 472f7fa has been approved by ebfull

@zkbot
Copy link
Copy Markdown
Contributor

zkbot commented Oct 14, 2018

⌛ Testing commit 472f7fa with merge e8f5e59...

zkbot added a commit that referenced this pull request Oct 14, 2018
@zkbot
Auto merge of #3602 - bitcartel:release-v2.0.1, r=ebfull
e8f5e59 
Release v2.0.1
@garethtdavies garethtdavies mentioned this pull request Oct 14, 2018
Closed
daira
daira approved these changes Oct 14, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@zkbot
Copy link
Copy Markdown
Contributor

zkbot commented Oct 14, 2018

☀️ Test successful - pr-merge
Approved by: ebfull
Pushing e8f5e59 to master...

@zkbot zkbot merged commit 472f7fa into zcash:master Oct 14, 2018
@str4d str4d removed their request for review April 2, 2019 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@daira daira daira approved these changes

+2 more reviewers

@ebfull ebfull ebfull approved these changes

@mdr0id mdr0id mdr0id approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

C-release Category: This is an issue corresponding to the creation of a specific release.

Projects

None yet

Milestone

v2.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@bitcartel @ebfull @zkbot @daira @mdr0id