Update release notes for v2.0.1#3601
Merged
zkbot merged 1 commit intozcash:masterfrom Oct 14, 2018
Merged
Conversation
Contributor
Author
|
From @ebfull "ACK from my phone. can’t do it on github atm" |
Contributor
Author
|
@zkbot r+ |
Contributor
|
📌 Commit cfcea81 has been approved by |
Contributor
daira
reviewed
Oct 14, 2018
|
|
||
| Enabled Sapling features for mainnet | ||
| ------------------------------------ | ||
| This release adds significant support for Sapling to the wallet and RPC interface. Sapling will activate at block 419200, which is expected to be mined on the 28th of October 2018. Users running v2.0.0 nodes (which are consensus-compatible with Sapling) will follow the network upgrade, but must upgrade to v2.0.1 in order to send Sapling shielded transactions. |
|
|
||
| Minimum Difficulty Blocks allowed on testnet | ||
| -------------------------------------------- | ||
| Sapling activated on testnet at block 280000. Users running v2.0.1 nodes no longer need to specify `-experimentalfeatures` and `-developersapling` to use Sapling functionality on testnet. Users running v2.0.0 nodes should upgrade to v2.0.1 which introduces a consensus rule change to allow minimum difficulty blocks to be mined from block 299188, thereby splitting the chain. |
Contributor
There was a problem hiding this comment.
The subheading doesn't reflect all of the content of this paragraph.
|
|
||
| Fix Signing Raw Transactions with Unsynced Offline Nodes | ||
| -------------------------------------------------------- | ||
| With v2.0.0, in `signrawtransaction` the consensus branch ID (which is used to construct the transaction) was estimated using the chain height. With v2.0.1 this has been improved by also considering the `APPROX_RELEASE_HEIGHT` of the release, and a new parameter to allow the caller to manually override the consensus branch ID that zcashd will use. |
Contributor
There was a problem hiding this comment.
Is it true that 2.0.0 uses estimated chain height? I don't remember that.
Contributor
Author
There was a problem hiding this comment.
Yes, for never synced nodes, this meant 0. https://github.com/zcash/zcash/pull/3520/files#diff-01aa7d1d32f1b9e5a836c9c411978918L877
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.