Replace Sapling support-related asserts with JSON errors#3536
Merged
zkbot merged 1 commit intozcash:masterfrom Sep 22, 2018
Merged
Replace Sapling support-related asserts with JSON errors#3536zkbot merged 1 commit intozcash:masterfrom
zkbot merged 1 commit intozcash:masterfrom
Conversation
This helps prevent users from triggering an assert if they pass in Sapling addresses to RPC calls: z_mergetoaddress, z_importviewingkey and z_exportviewingkey.
Contributor
Author
|
I ran tests with testnet node. e.g. and |
ebfull
approved these changes
Sep 21, 2018
mdr0id
approved these changes
Sep 21, 2018
Contributor
|
@zkbot r+ |
Contributor
|
📌 Commit f1cb49a has been approved by |
Contributor
zkbot
added a commit
that referenced
this pull request
Sep 21, 2018
…=str4d Replace Sapling support-related asserts with JSON errors This helps prevent users from triggering an assert if they pass in Sapling addresses to RPC calls which do not fully support Sapling yet: z_mergetoaddress, z_importviewingkey and z_exportviewingkey. Part of #3533.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps prevent users from triggering an assert if they pass in Sapling addresses to RPC calls which do not fully support Sapling yet: z_mergetoaddress, z_importviewingkey and z_exportviewingkey.
Part of #3533.