Merged
Conversation
This was referenced Jun 15, 2021
Merged
jakirkham
reviewed
Jun 16, 2021
requirements_dev_optional.txt
Outdated
Comment on lines
+19
to
+22
| s3fs==2021.5.0; python_version > '3.6' | ||
| fsspec==2021.5.0; python_version > '3.6' | ||
| moto[server]>=1.3.14; python_version > '3.6' | ||
| s3fs==2021.5.0; python_version > '3.7' | ||
| fsspec==2021.5.0; python_version > '3.7' | ||
| moto[server]>=1.3.14; python_version > '3.7' |
Member
There was a problem hiding this comment.
I think we can just drop python_version. Believe this was just here because these packages didn't exist for Python 3.6
jakirkham
reviewed
Jun 16, 2021
requirements_dev_numpy.txt
Outdated
| # different versions of numpy. This file should pin to the latest | ||
| # numpy version. | ||
| numpy==1.20.3; python_version >= '3.6' No newline at end of file | ||
| numpy==1.20.3; python_version >= '3.7' |
Member
There was a problem hiding this comment.
Suggested change
| numpy==1.20.3; python_version >= '3.7' | |
| numpy==1.20.3 |
jakirkham
reviewed
Jun 16, 2021
Member
jakirkham
left a comment
There was a problem hiding this comment.
Thanks Josh! 😄 Looks good. Had a couple minor suggestions to simplify things going forward
Member
Author
|
Pushed. Assuming that all goes green, let's get this in since other PRs are now failing due to the missing |
jakirkham
approved these changes
Jun 16, 2021
Member
Author
|
Thanks, @jakirkham. I'll start getting open PRs green. |
joshmoore
added a commit
to joshmoore/zarr-python
that referenced
this pull request
Jun 17, 2021
see: * zarr-developers#774 which drops Python 3.6 * zarr-developers#749 which bumps h5py to 3.2
joshmoore
added a commit
that referenced
this pull request
Jun 17, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see positive vote in #765
TODO: