Skip to content

Fix fill_value handling for complex dtypes#2200

Merged
dcherian merged 12 commits intozarr-developers:v3from
dcherian:fix-prop-test-fillvalue
Sep 25, 2024
Merged

Fix fill_value handling for complex dtypes#2200
dcherian merged 12 commits intozarr-developers:v3from
dcherian:fix-prop-test-fillvalue

Conversation

@dcherian
Copy link
Contributor

@dcherian dcherian commented Sep 17, 2024 •
edited
Loading

Broken out of #2189

  1. Property test now tests arbitrary fill_values of the right dtype, as well as None
  2. All handle v2, v3 dtypes

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@dcherian dcherian force-pushed the fix-prop-test-fillvalue branch from 005279c to 33f20d3 Compare September 17, 2024 20:27
jhamman
jhamman reviewed Sep 17, 2024
View reviewed changes
@dcherian
Copy link
Contributor Author

dcherian commented Sep 17, 2024

FWIW the zarr.json is

{
  "shape": [
    1
  ],
  "fill_value": 0,
  "chunk_grid": {
    "name": "regular",
    "configuration": {
      "chunk_shape": [
        1
      ]
    }
  },
  "attributes": {},
  "zarr_format": 3,
  "data_type": "datetime64[Y]",
  "chunk_key_encoding": {
    "name": "default",
    "configuration": {
      "separator": "/"
    }
  },
  "codecs": [
    {
      "name": "bytes",
      "configuration": {
        "endian": "little"
      }
    }
  ],
  "node_type": "array"
}

@jhamman jhamman mentioned this pull request Sep 18, 2024
Merged
6 tasks
@dcherian dcherian force-pushed the fix-prop-test-fillvalue branch from 566ec13 to e31cb6f Compare September 24, 2024 03:54
@dcherian dcherian changed the title Fix fill_value handling for complex & datetime dtypes Fix fill_value handling for complex dtypes Sep 24, 2024
@dcherian dcherian force-pushed the fix-prop-test-fillvalue branch from 1087178 to 2a973b0 Compare September 24, 2024 04:45
@dcherian dcherian requested a review from jhamman September 24, 2024 04:46
dcherian
dcherian commented Sep 24, 2024
View reviewed changes
src/zarr/core/buffer/core.py
data, other = np.broadcast_arrays(self._data, other)
result = np.array_equal(self._data, other, equal_nan=equal_nan)
result = np.array_equal(
self._data, other, equal_nan=equal_nan if self._data.dtype.kind not in "US" else False
Copy link
Contributor Author

@dcherian dcherian Sep 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also needed for V2

normanrz
normanrz reviewed Sep 24, 2024
View reviewed changes
@dcherian
Copy link
Contributor Author

dcherian commented Sep 25, 2024

pre-commit.ci autofix

@dcherian dcherian merged commit 692593b into zarr-developers:v3 Sep 25, 2024
@dcherian dcherian deleted the fix-prop-test-fillvalue branch September 25, 2024 16:47
dcherian added a commit to dcherian/zarr-python that referenced this pull request Sep 27, 2024
@dcherian
Merge branch 'v3' into generalize-stateful-store
ae3bca5 
* v3: (21 commits)
  Default zarr.open to open_group if shape is not provided (zarr-developers#2158)
  feat: metadata-only support for storage transformers metadata (zarr-developers#2180)
  fix(async): set default concurrency to 10 tasks (zarr-developers#2256)
  chore(deps): drop support for python 3.10 and numpy 1.24 (zarr-developers#2217)
  feature(store): add LoggingStore wrapper (zarr-developers#2231)
  Apply assorted ruff/flake8-simplify rules (SIM) (zarr-developers#2259)
  Add array storage helpers (zarr-developers#2065)
  Apply ruff/flake8-annotations rule ANN204 (zarr-developers#2258)
  No need to run DeepSource any more - we use ruff (zarr-developers#2261)
  Remove unnecessary lambda expression (zarr-developers#2260)
  Enforce ruff/flake8-comprehensions rules (C4) (zarr-developers#2239)
  Use `map(str, *)` in `test_accessed_chunks` (zarr-developers#2229)
  Replace Gitter with Zulip (zarr-developers#2254)
  Enforce ruff/flake8-pytest-style rules (PT) (zarr-developers#2236)
  Fix multiple identical imports (zarr-developers#2241)
  Enforce ruff/flake8-return rules (RET) (zarr-developers#2237)
  Enforce ruff/flynt rules (FLY) (zarr-developers#2240)
  Fix fill_value handling for complex dtypes (zarr-developers#2200)
  Update V2 codec pipeline to use concrete classes (zarr-developers#2244)
  Apply and enforce more ruff rules (zarr-developers#2053)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@normanrz normanrz normanrz left review comments

@d-v-b d-v-b d-v-b left review comments

@jhamman jhamman jhamman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dcherian @normanrz @jhamman @d-v-b