Build for Linux AArch64 and other miscellaneous cleanups#710
Build for Linux AArch64 and other miscellaneous cleanups#710dstansby merged 11 commits intozarr-developers:mainfrom
Conversation
|
Thanks! Launched. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #710 +/- ##
=======================================
Coverage 99.96% 99.96%
=======================================
Files 63 63
Lines 2754 2754
=======================================
Hits 2753 2753
Misses 1 1 🚀 New features to boost your workflow:
|
Perhaps see conda-incubator/setup-miniconda#385 |
Suggested-by: <josh@openmicroscopy.org>
|
Thanks! That should be fixed with 6b05be5. Also, I'm sorry – I didn't notice that there is an open PR for this: #315. I should have checked! I noticed a few prior attempts when scrolling through #288, but I didn't see that PR as it wasn't linked to the issue 🙈 I would be happy to go forward with whatever is suggested. |
|
In the meantime, I added a CHANGELOG entry for this change via 82a4565. I am happy to preserve authorship from the previous PRs or close my PR; either option is acceptable to me. |
|
|
Ah, thanks – I'll have to take a look at that; I don't immediately see why that happens. The only reference to |
|
I guess we aren't linking |
|
@joshmoore, the tests should be fixed now. They ran on my fork and passed (see logs); the failure sign there is just because the Codecov token won't be set up in my fork's settings. Could you please relaunch the workflows here? |
|
Launched. |
|
Thanks! :) The Ubuntu-3.11 failure looks like a sporadic one. |
|
Thanks @agriyakhetarpal, I am excited for this to land! When launching the devcontainer of pipefunc building numcodecs takes like 99% of the time, even though I am installing ≈200 dependencies. Hope this PR will have the momentum to get merged (unlike #315 which seems inactive). |
|
Thanks, @basnijholt; I'm happy to address any review comments that might come up, though I think the PR is complete from my end. I intend to keep it up to date. 😃 |
|
(Relaunched the flaky 3.11 build) |
dstansby
left a comment
There was a problem hiding this comment.
Thanks a lot for this PR - build times are so much better now we can use a native runner! I just had one question where it looks like old code can be removed, but once that's dealt with I will approve, and hopefully we can get this into a release 🙌
Co-Authored-By: David Stansby <d.stansby@ucl.ac.uk>
|
@dstansby, thanks for the review! All good to go, now. |
|
Relaunched. |
This PR closes #288; it adds the new ubuntu-22.04-arm runner to build Linux AArch64/arm64 wheels. SSE2 and AVX2 x86-specific SIMD optimizations have been disabled at build time. This is in line with Spack downstream: spack/spack#40754. Additionally, the minimum macOS deployment target has been bumped from 10.9 to 10.13 (High Sierra), as CPython supports 10.13+ post 3.12.6, which is used by
cibuildwheel's GitHub Action.I've moved some code in
setup.pyto dedicated functions for now, but I agree with the direction in #464 wherein moving to a more modern build system in comparison tosetuptoolshas been suggested; it sounds like a better long-term solution.Additional context: https://github.blog/changelog/2025-01-16-linux-arm64-hosted-runners-now-available-for-free-in-public-repositories-public-preview/
TODO: