Skip to content

py-numcodecs: fix broken sse / avx2 variables#40754

Merged
adamjstewart merged 1 commit intospack:developfrom
haampie:fix/numcodecs
Oct 29, 2023
Merged

py-numcodecs: fix broken sse / avx2 variables#40754
adamjstewart merged 1 commit intospack:developfrom
haampie:fix/numcodecs

Conversation

@haampie
Copy link
Member

@haampie haampie commented Oct 28, 2023

Fixes #40740

Copy link
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. @eugeneswalker why didn't CI catch this bug if this package is in the E4S stack?

@adamjstewart adamjstewart self-assigned this Oct 28, 2023
@eugeneswalker
Copy link
Contributor

eugeneswalker commented Oct 28, 2023

Makes sense to me. @eugeneswalker why didn't CI catch this bug if this package is in the E4S stack?

It only comes in as a dependency of libpressio which is not enabled in the ARM and PPC E4S stacks, which is where we see this error.

@adamjstewart
Copy link
Member

@eugeneswalker can you confirm this solves your issue?

@eugeneswalker
Copy link
Contributor

@eugeneswalker can you confirm this solves your issue?

This PR resolves #40740 for me, yes, I can confirm. Thanks!

ARM64

==> Installing py-numcodecs-0.11.0-trfpazya45mmrats52y6no7q3xy3jrft [47/47]
==> No binary for py-numcodecs-0.11.0-trfpazya45mmrats52y6no7q3xy3jrft found: installing from source
==> Fetching https://files.pythonhosted.org/packages/source/n/numcodecs/numcodecs-0.11.0.tar.gz
==> No patches needed for py-numcodecs
==> py-numcodecs: Executing phase: 'install'
==> py-numcodecs: Successfully installed py-numcodecs-0.11.0-trfpazya45mmrats52y6no7q3xy3jrft
  Stage: 1.54s.  Install: 2m 11.88s.  Post-install: 0.09s.  Total: 2m 13.99s
[+] /spack/opt/spack/linux-ubuntu20.04-aarch64/gcc-11.4.0/py-numcodecs-0.11.0-trfpazya45mmrats52y6no7q3xy3jrft

PPC64

==> Installing py-numcodecs-0.11.0-6cifsdt3lhvoyo53kh3m3a26452bnztm [46/46]
==> No binary for py-numcodecs-0.11.0-6cifsdt3lhvoyo53kh3m3a26452bnztm found: installing from source
==> Using cached archive: /spack/var/spack/cache/_source-cache/archive/6c/6c058b321de84a1729299b0eae4d652b2e48ea1ca7f9df0da65cb13470e635eb.tar.gz
==> No patches needed for py-numcodecs
==> py-numcodecs: Executing phase: 'install'
==> py-numcodecs: Successfully installed py-numcodecs-0.11.0-6cifsdt3lhvoyo53kh3m3a26452bnztm
  Stage: 0.17s.  Install: 2m 33.11s.  Post-install: 0.18s.  Total: 2m 33.70s
[+] /spack/opt/spack/linux-ubuntu20.04-ppc64le/gcc-9.4.0/py-numcodecs-0.11.0-6cifsdt3lhvoyo53kh3m3a26452bnztm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

py-numcodecs@0.11.0 fails build on ARM64 and PPC64: gcc: error: unrecognized command line option '-mno-avx2'

3 participants