Don't overwrite codec config values when set.#700
Merged
d-v-b merged 5 commits intozarr-developers:mainfrom Feb 8, 2025
Merged
Don't overwrite codec config values when set.#700d-v-b merged 5 commits intozarr-developers:mainfrom
d-v-b merged 5 commits intozarr-developers:mainfrom
Conversation
A codec doesn't know where it is in the codec pipeline, so it cannot know whether `array_spec.dtype` should match `codec.dtype` or not.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #700 +/- ##
==========================================
- Coverage 99.78% 99.74% -0.04%
==========================================
Files 63 63
Lines 2754 2753 -1
==========================================
- Hits 2748 2746 -2
- Misses 6 7 +1
🚀 New features to boost your workflow:
|
d-v-b
approved these changes
Feb 7, 2025
d-v-b
approved these changes
Feb 7, 2025
Contributor
|
I requested Norman for a review, since he originally wrote this code. Would be good to add some release notes too to explain what's fixed/changed for users. |
4 tasks
Contributor
Author
|
Sweet can we release to unbreak Zar? |
Contributor
|
i have no idea how to do a release but we should absolutely do one |
Contributor
|
@dcherian I cut a release with this fix |
dcherian
added a commit
to dcherian/zarr-python
that referenced
this pull request
Feb 10, 2025
Fix is in upstream zarr-developers/numcodecs#700 Closes zarr-developers#2800
6 tasks
dcherian
added a commit
to dcherian/zarr-python
that referenced
this pull request
Feb 10, 2025
Fix is in upstream zarr-developers/numcodecs#700 Closes zarr-developers#2800
dcherian
added a commit
to zarr-developers/zarr-python
that referenced
this pull request
Feb 10, 2025
* Regression test for codec overwriting. Fix is in upstream zarr-developers/numcodecs#700 Closes #2800 * add note * fix skip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A codec doesn't know where it is in the codec pipeline, so it cannot know whether
array_spec.dtypeshould matchcodec.dtypeor not. So I don't think it's appropriate to overwrite or even raise a warning or error.TODO: