Remove unused pytest skip#651
Merged
dstansby merged 1 commit intozarr-developers:mainfrom Nov 19, 2024
dstansby:full-coverage
Merged
Remove unused pytest skip#651dstansby merged 1 commit intozarr-developers:mainfrom dstansby:full-coverage
dstansby merged 1 commit intozarr-developers:mainfrom
dstansby:full-coverage
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #651 +/- ##
==========================================
+ Coverage 99.81% 99.92% +0.11%
==========================================
Files 62 62
Lines 2712 2721 +9
==========================================
+ Hits 2707 2719 +12
+ Misses 5 2 -3
|
jakirkham
approved these changes
Nov 19, 2024
Member
|
Thanks David! 🙏 This seems reasonable If we think we do need this condition, we could also add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I originally included the
pytest.skipbecause in rare cases (I think debug builds of Cpython??) docstrings can returnNoneinstead of their contents. I think this is rare enough that we don't need to care about it, and it's better just adding a# type: ignorecomment instead of apytest.skip.I'm hoping this gets code coverage back up to 100% again to fix #646