Skip to content

Missing coverage? #646

New issue
New issue
Open
#651
Open
Missing coverage?#646
#651
@jakirkham

Description

@jakirkham
jakirkham
opened on Nov 17, 2024

In the recent CodeCov report, they flag these lines as uncoverged

numcodecs/numcodecs/json.py

Lines 68 to 72 in ad1ad67

def encode(self, buf):
try:
buf = np.asarray(buf)
except ValueError:
buf = np.asarray(buf, dtype=object)

It is a little unclear why as those lines were introduced with corresponding tests some time ago in PR ( #417 ). AFAICT recent NumPy versions still need to use that fallback. In fact that behavior is expected and defined in NEP 34

This may need further investigation to resolve

Additionally CodeCov flags this line as uncovered.

numcodecs/numcodecs/tests/test_zarr3.py

Lines 51 to 55 in ad1ad67

@pytest.mark.parametrize("codec_class", ALL_CODECS)
def test_docstring(codec_class: type[numcodecs.zarr3._NumcodecsCodec]):
if codec_class.__doc__ is None:
pytest.skip()
assert "See :class:`numcodecs." in codec_class.__doc__

Just looking at it, would naively add a # pragma: no cover, but wanted to mention it here in case there is something I'm missing

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions