Fix indexing with nones#730
Merged
maxrjones merged 3 commits intozarr-developers:mainfrom Jul 24, 2025
Merged
Conversation
maxrjones
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures we obey the "(excluding
None)" clause here, instead of raising over-eagerly. We missed this from #612.In general we should probably refactor the indexing code to follow all the rules in the array API, else xarray could change it's internals again in a way that bites us again (which is what happened here - see #596).
tcoordinate on V2 #728docs/releases.rstNew functions/methods are listed inapi.rstNew functionality has documentation