Support ManifestArray expansion via None in the indexer#612
Merged
Support ManifestArray expansion via None in the indexer#612
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #612 +/- ##
===========================================
+ Coverage 89.34% 89.40% +0.05%
===========================================
Files 34 34
Lines 1943 1944 +1
===========================================
+ Hits 1736 1738 +2
+ Misses 207 206 -1
🚀 New features to boost your workflow:
|
chuckwondo
approved these changes
Jun 11, 2025
Collaborator
chuckwondo
left a comment
There was a problem hiding this comment.
Thanks @maxrjones! Looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds ManifestArray support this component of the array API:
Fixes #596