Skip to content

feat(state): deprecate "nodeport" in registry info in favor of "node"#4729

Merged
brandtkeller merged 6 commits intomainfrom
nodeport-to-node
Mar 31, 2026
Merged

feat(state): deprecate "nodeport" in registry info in favor of "node"#4729
brandtkeller merged 6 commits intomainfrom
nodeport-to-node

Conversation

@AustinAbro321
Copy link
Copy Markdown
Member

Description

Fixes #4711

Checklist before merging

Signed-off-by: Austin Abro <austinabro321@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Mar 19, 2026

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 9d34612
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/69bc55a321eb530008e576af

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 19, 2026

Codecov Report

❌ Patch coverage is 60.60606% with 13 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pkg/state/state.go 14.28% 12 Missing ⚠️
src/pkg/packager/deploy.go 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/cmd/initialize.go 26.88% <100.00%> (+1.06%) ⬆️
src/cmd/viper.go 54.44% <ø> (ø)
src/internal/packager/template/template.go 77.31% <100.00%> (+0.23%) ⬆️
src/pkg/cluster/cluster.go 47.20% <100.00%> (+0.51%) ⬆️
src/pkg/packager/deploy.go 0.00% <0.00%> (ø)
src/pkg/state/state.go 26.98% <14.28%> (-0.55%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review March 20, 2026 16:13
@AustinAbro321 AustinAbro321 requested review from a team as code owners March 20, 2026 16:13
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - worked through a few different install/upgrade scenarios and do not see a change in behavior.

@brandtkeller brandtkeller added this pull request to the merge queue Mar 31, 2026
Merged via the queue into main with commit c8dd855 Mar 31, 2026
43 checks passed
@brandtkeller brandtkeller deleted the nodeport-to-node branch March 31, 2026 20:59
@github-project-automation github-project-automation Bot moved this to Done in Zarf Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

rename nodeport to port in state.RegistryInfo

2 participants