Describe what should be investigated or refactored
In the the state.RegistryInfo struct, the field nodeport is used for the internal registry port. It represents the internal port of the registry in nodeport mode and the new proxy mode. However, since proxy mode uses a hostport and not a nodeport this ends up being confusing. We should introduce a new field called port or internalPort to hold this information. Care will have to be taken to deprecate the nodeport field for backwards compatibility.
We may also want to change the nodeport flag from --nodeport to --registry-port. We will definitely want to change the chart from not using .Values.service.nodeport as the value for nodeport.
Describe what should be investigated or refactored
In the the
state.RegistryInfostruct, the fieldnodeportis used for the internal registry port. It represents the internal port of the registry in nodeport mode and the new proxy mode. However, since proxy mode uses a hostport and not a nodeport this ends up being confusing. We should introduce a new field calledportorinternalPortto hold this information. Care will have to be taken to deprecate the nodeport field for backwards compatibility.We may also want to change the nodeport flag from
--nodeportto--registry-port. We will definitely want to change the chart from not using .Values.service.nodeport as the value for nodeport.