Skip to content

feat: error early during healthchecks when status is terminal#4547

Merged
AustinAbro321 merged 5 commits intomainfrom
exit-early-on-failure
Jan 23, 2026
Merged

feat: error early during healthchecks when status is terminal#4547
AustinAbro321 merged 5 commits intomainfrom
exit-early-on-failure

Conversation

@AustinAbro321
Copy link
Copy Markdown
Member

@AustinAbro321 AustinAbro321 commented Jan 22, 2026

Description

Helm recently made this improvement which made me realize this was also sub-optimal behavior in Zarf. helm/helm#31730.

Checklist before merging

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Austin Abro <austinabro321@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 22, 2026

Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit 52851c8
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/697390a634e27f0008136874

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

Files with missing lines Coverage Δ
src/internal/healthchecks/healthchecks.go 59.52% <100.00%> (+2.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Austin Abro <austinabro321@gmail.com>
@AustinAbro321 AustinAbro321 marked this pull request as ready for review January 23, 2026 13:50
@AustinAbro321 AustinAbro321 requested review from a team as code owners January 23, 2026 13:50
brandtkeller
brandtkeller previously approved these changes Jan 23, 2026
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor thought others lgtm

Comment thread src/internal/healthchecks/healthchecks.go Outdated
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Copy link
Copy Markdown
Member

@brandtkeller brandtkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@AustinAbro321 AustinAbro321 added this pull request to the merge queue Jan 23, 2026
Merged via the queue into main with commit eb54546 Jan 23, 2026
30 checks passed
@AustinAbro321 AustinAbro321 deleted the exit-early-on-failure branch January 23, 2026 17:57
@github-project-automation github-project-automation Bot moved this to Done in Zarf Jan 23, 2026
chaospuppy pushed a commit to chaospuppy/zarf that referenced this pull request Jan 23, 2026
…ev#4547)

Signed-off-by: Austin Abro <austinabro321@gmail.com>
Signed-off-by: Tim Seagren <timseagren@defenseunicorns.com>
AustinAbro321 added a commit that referenced this pull request Feb 4, 2026
Signed-off-by: Austin Abro <austinabro321@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants