feat: error when building a package with zero components#3403
Merged
AustinAbro321 merged 8 commits intomainfrom Feb 3, 2025
Merged
feat: error when building a package with zero components#3403AustinAbro321 merged 8 commits intomainfrom
AustinAbro321 merged 8 commits intomainfrom
Conversation
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
✅ Deploy Preview for zarf-docs canceled.
|
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
Contributor
|
The current tests do not cover a package with components that are filtered out due to flavor filtering, which a believe is what is described in the issue. |
Member
Author
|
@phillebaba Would you suggest that I move the logic to |
Contributor
|
I dont have a problem with having the existing test, but I would probably not close the issue with this PR. Adding a test to loadPackage would probably be the best way to solve this. |
Signed-off-by: Austin Abro <AustinAbro321@gmail.com>
Member
Author
|
Updated with a test on loadPackage |
phillebaba
previously approved these changes
Jan 24, 2025
c2c5dbb to
0d681d0
Compare
nevinaragam
pushed a commit
to nevinaragam/zarf
that referenced
this pull request
May 20, 2025
Signed-off-by: Austin Abro <AustinAbro321@gmail.com> Signed-off-by: NevinAragam <nevin.aragam@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #3307
Checklist before merging