Add ExitOnInterrupt utils function; catch interrupts when using wait#1891
Merged
Noxsios merged 6 commits intozarf-dev:mainfrom Jul 10, 2023
Merged
Add ExitOnInterrupt utils function; catch interrupts when using wait#1891Noxsios merged 6 commits intozarf-dev:mainfrom
Noxsios merged 6 commits intozarf-dev:mainfrom
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
Contributor
Author
|
The ticket (and this PR) is specific to the |
a7cca5c to
bf34db4
Compare
Racer159
suggested changes
Jul 9, 2023
Contributor
Racer159
left a comment
There was a problem hiding this comment.
Thanks for the PR! Just a few small change but otherwise looks good.
Contributor
Author
|
Thank you for the feedback. Beyond your changes, I've pushed the following additional changes:
|
d28e1f3 to
520b228
Compare
Replace arguments with re-useable error Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
Replace arguments with re-useable error Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
520b228 to
e26de8f
Compare
YrrepNoj
approved these changes
Jul 10, 2023
cmwylie19
pushed a commit
that referenced
this pull request
Jul 10, 2023
…1891) Add ExitOnInterrupt utils function; catch interrupts when using wait ## Description Add ability to catch interrupts when using wait command. ## Related Issue Fixes #1864 ## Type of change - [X] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [X] Test, docs, adr added or updated as needed - [X] [Contributor Guide Steps](https://github.com/defenseunicorns/zarf/blob/main/CONTRIBUTING.md#developer-workflow) followed --------- Co-authored-by: Wayne Starr <Racer159@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add ExitOnInterrupt utils function; catch interrupts when using wait
Description
Add ability to catch interrupts when using wait command.
Related Issue
Fixes #1864
Type of change
Checklist before merging