fix duplicate gids in container creation#3019
Merged
utam0k merged 1 commit intoyouki-dev:mainfrom Dec 14, 2024
Merged
Conversation
6c7e85c to
ab9998e
Compare
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com>
ab9998e to
c1fdf87
Compare
utam0k
approved these changes
Dec 14, 2024
Merged
YamasouA
pushed a commit
to YamasouA/youki
that referenced
this pull request
Feb 2, 2025
Signed-off-by: Yashodhan Joshi <yjdoc2@gmail.com> Signed-off-by: Akiyama <akiakiskyhand@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we provide duplicate gids in additional_gids runc simply ignores them, we should do the same. This PR fixes it and adds an e2e for the same.
Carried over from #3018