Remove GraphViz feature #1485
Merged
Remove GraphViz feature #1485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yonaskolb
approved these changes
Jul 2, 2024
freddi-kit
approved these changes
Jul 2, 2024
Collaborator
freddi-kit
left a comment
There was a problem hiding this comment.
I found there is graphviz in
but not related so much 😂
Collaborator
Author
I checked this test fixture. It depends on XcodeGenKit itself, so it's better to update them for the current situation. |
asifmohd
added a commit
to asifmohd/XcodeGen
that referenced
this pull request
Oct 22, 2024
This reverts commit 7eb5e9b.
asifmohd
added a commit
to asifmohd/XcodeGen
that referenced
this pull request
Oct 22, 2024
This reverts commit 7eb5e9b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1483 closes #1462
I found XcodeGen can't build with Xcode 16 and Swift 6 compilers due to GraphViz.
It might be caused by Swift compiler's bug so it will be fixed until the stable release.
However, GraphViz is no longer maintained, so I suggest dropping this dependency for future maintainability.
This PR drops
dump --type graphvizfeature.