Skip to content

Support default setting overrides on different languages#1368

Merged
jamesmaa merged 14 commits intoyomidevs:masterfrom
jamesmaa:default-settings
Oct 25, 2024
Merged

Support default setting overrides on different languages#1368
jamesmaa merged 14 commits intoyomidevs:masterfrom
jamesmaa:default-settings

Conversation

@jamesmaa
Copy link
Copy Markdown
Collaborator

@jamesmaa jamesmaa commented Aug 28, 2024 •
edited
Loading

Fixes #1328

  • : Use a modal instead of confirm
  • : Applying overrides updates UI elements in settings page
  • : Schema validation for overrides
  • : Valid setting validation: auto caught by settings-controller
  • : Tests: not doing
image

jamesmaa
jamesmaa commented Aug 29, 2024
View reviewed changes
Comment thread ext/js/pages/settings/languages-controller.js Outdated
@Casheeew Casheeew added kind/enhancement The issue or PR is a new feature or request area/ui-ux The issue or PR is related to UI/UX/Design labels Sep 17, 2024
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Oct 13, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #1368 will not alter performance

Comparing jamesmaa:default-settings (dc66a2e) with master (d6b2315)

Summary

✅ 3 untouched benchmarks

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Oct 15, 2024 •
edited
Loading

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

@jamesmaa jamesmaa marked this pull request as ready for review October 17, 2024 17:11
@jamesmaa jamesmaa requested a review from a team as a code owner October 17, 2024 17:11
Kuuuube
Kuuuube requested changes Oct 17, 2024
View reviewed changes
Comment thread ext/templates-settings.html Outdated
Comment thread ext/templates-modals.html Outdated
Comment thread ext/templates-modals.html Outdated
@jamesmaa
Copy link
Copy Markdown
Collaborator Author

jamesmaa commented Oct 18, 2024

comments addressed. current look
image

image

@jamesmaa jamesmaa requested a review from Kuuuube October 18, 2024 18:02
Kuuuube
Kuuuube approved these changes Oct 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Kuuuube Kuuuube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to merge but I feel like we should probably add overrides to turn off the scan whole word stuff when selecting japanese, chinese, cantonese, and korean.

@jamesmaa jamesmaa added this pull request to the merge queue Oct 25, 2024
Merged via the queue into yomidevs:master with commit 72a3477 Oct 25, 2024
@jamesmaa jamesmaa deleted the default-settings branch October 25, 2024 18:08
@MarvNC
Copy link
Copy Markdown
Member

MarvNC commented Oct 26, 2024

msedge_Support_default_setting_overrides_on_different_lan_2024-10-26_03-27-42

Playwright breakage seems to have been caused by this PR

MarvNC added a commit to MarvNC/yomitan that referenced this pull request Oct 26, 2024
@MarvNC
Revert "Support default setting overrides on different languages (yom…
52fc8f5 
…idevs#1368)"

This reverts commit 72a3477.
@MarvNC MarvNC mentioned this pull request Oct 26, 2024
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Oct 26, 2024
@MarvNC
Revert "Support default setting overrides on different languages (#1368…
019c458 
…)" (#1530)

This reverts commit 72a3477.
jamesmaa added a commit to jamesmaa/yomitan that referenced this pull request Oct 27, 2024
@jamesmaa
Reapply "Support default setting overrides on different languages (yo…
2e46f5d 
…midevs#1368)" (yomidevs#1530)

This reverts commit 019c458.
jamesmaa added a commit to jamesmaa/yomitan that referenced this pull request Oct 27, 2024
@jamesmaa
Revert "Reapply "Support default setting overrides on different langu…
856fefe 
…ages (yomidevs#1368)" (yomidevs#1530)"

This reverts commit 2e46f5d.
MarvNC pushed a commit to MarvNC/yomitan that referenced this pull request Oct 27, 2024
@jamesmaa @MarvNC
Support default setting overrides on different languages (yomidevs#1368)
80a082f 
* WIP

* Update only when there are setting overrides

* Display overrides

* Add schema validation

* Fix types

* --wip-- [skip ci]

* --wip-- [skip ci]

* Changes

* Unneeded changes

* Fix types

* Render all mod types

* Fix french text replacements

* Address comments

* Add languages with spaces
jamesmaa added a commit to jamesmaa/yomitan that referenced this pull request Oct 28, 2024
@jamesmaa
Reapply "Support default setting overrides on different languages (yo…
2a61c69 
…midevs#1368)" (yomidevs#1530)

This reverts commit 019c458.
jamesmaa added a commit to jamesmaa/yomitan that referenced this pull request Oct 28, 2024
@jamesmaa
Reapply "Support default setting overrides on different languages (yo…
dd70fae 
…midevs#1368)" (yomidevs#1530)

This reverts commit 019c458.
@Kuuuube Kuuuube mentioned this pull request Oct 28, 2024
Merged
jamesmaa added a commit to jamesmaa/yomitan that referenced this pull request Oct 29, 2024
@jamesmaa
Reapply "Support default setting overrides on different languages (yo…
a4a683a 
…midevs#1368)" (yomidevs#1530)

This reverts commit 019c458.
github-merge-queue Bot pushed a commit that referenced this pull request Nov 1, 2024
@jamesmaa
Reapply "Support default setting overrides on different languages (#1… (
7c198d4 
#1535)

* Reapply "Support default setting overrides on different languages (#1368)" (#1530)

This reverts commit 019c458.

* Make recommended settings lazy-load
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Kuuuube Kuuuube Kuuuube approved these changes

Assignees

No one assigned

Labels

area/ui-ux The issue or PR is related to UI/UX/Design kind/enhancement The issue or PR is a new feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support default settings by language

4 participants

@jamesmaa @MarvNC @Kuuuube @Casheeew