Max & Maya: Make sure validators being shown in the Publisher UI when they set to be optional in AYON setting #201
Conversation
…ose whether it should be included in maya/max for validation
client/ayon_core/hosts/maya/plugins/publish/validate_arnold_scene_source_cbid.py
Show resolved
Hide resolved
client/ayon_core/hosts/maya/plugins/publish/validate_current_renderlayer_renderable.py
Show resolved
Hide resolved
client/ayon_core/hosts/maya/plugins/publish/validate_look_shading_group.py
Show resolved
Hide resolved
BigRoy
left a comment
There was a problem hiding this comment.
I'm personally not a fan of just throwing this into ALL validator plug-ins. Some just really aren't meant to ever be optional plus it's more code to maintain - and in the end does more 'logic' per plug-in and thus will be (maybe measurably?) slower to run.
Anyway, I can see how having the consistency might make it 'less error prone' on changes in the future if someone did start exposing one to settings. But half of these plug-ins don't have matching "optional" settings I believe, and thus this logic being implemented now "does nothing meaningful" because the plug-ins are never actually optional.
So I'd recommend just 'fixing' the ones that need fixing - instead of cluttering it across all plug-ins where it doesn't currently do anything useful. OR add them all to the customizable settings?
We are not making any new validator optional here, I suppose. We are just fixing the ones that already have optional tag in settings to propagate it to the publishing window so they are really optional.
|
Thanks, yes. Kayla just hit me up on discord in a PM as well mentioning these were already in the settings - in that case. Great fixing! 🧑🔧 |
Changelog Description
This PR is to make sure validators being shown correctly in the Publisher UI when they are being set to be optional in AYON setting.
Additional info
n/a
Testing notes: