Skip to content

Bugfix: Make houdini submissions respect pools groups#10

Merged
antirotor merged 13 commits intodevelopfrom
bugfix/OP-7353-make_houdini_submissions_respect_pools_groups
Mar 19, 2024
Merged

Bugfix: Make houdini submissions respect pools groups#10
antirotor merged 13 commits intodevelopfrom
bugfix/OP-7353-make_houdini_submissions_respect_pools_groups

Conversation

@MustafaJafar
Copy link
Copy Markdown
Member

@MustafaJafar MustafaJafar commented Feb 8, 2024 •
edited
Loading

Changelog Description

Make houdini submissions respect pools groups.
This is done by:

  1. Make collect pools works with some Houdini families/product types.
  2. Make Ayon Houdini submitters get group names from Houdini deadline settings.

Additional info

I made three Houdini deadline setting categories. each for a particular case.
image

Testing notes:

  1. Set pools and groups in ayon deadline addon settings
  2. Publish render and cache to deadline.

iLLiCiTiT
iLLiCiTiT reviewed Feb 9, 2024
View reviewed changes
@MustafaJafar MustafaJafar force-pushed the bugfix/OP-7353-make_houdini_submissions_respect_pools_groups branch from 765e9cc to 80e3246 Compare February 9, 2024 09:26
@MustafaJafar
Copy link
Copy Markdown
Member Author

MustafaJafar commented Feb 9, 2024

While I don't know what should I do on deadline server to test this so I printed the job info in ayon log and it seems to have the proper info in the job info.

DEBUG: DeadlineJobInfo(Plugin='Houdini'
 Frames='1001-1001x1'
 Name='robo_BigRobo_cfx_v166.hip - mantra_ropSplit [EXPORT IFD]'
 Comment=''
 Department=None
 BatchName='robo_BigRobo_cfx_v166.hip'
 UserName='Mustafa_Taher'
 MachineName='Major-Kalawy'
 Pool='ayon'
 SecondaryPool='none'
 Group='export_machines'
 Priority=50
 ChunkSize=10
 .
 .
 .

DEBUG: DeadlineJobInfo(Plugin='Mantra'
 Frames='1001-1001x1'
 Name='robo_BigRobo_cfx_v166.hip - mantra_ropSplit [RENDER]'
 Comment=''
 Department=None
 BatchName='robo_BigRobo_cfx_v166.hip'
 UserName='Mustafa_Taher'
 MachineName='Major-Kalawy'
 Pool='ayon'
 SecondaryPool='none'
 Group='render_machines'
 Priority=50
 ChunkSize=1
.
.
.

DEBUG: DeadlineJobInfo(Plugin='Houdini'
 Frames='1001-1001x1'
 Name='robo_BigRobo_cfx_v166.hip - pointcacheBgeoFarmTest [PUBLISH]'
 Comment=''
 Department=None
 BatchName='Robo - robo_BigRobo_cfx_v166.hip'
 UserName='Mustafa_Taher'
 MachineName='Major-Kalawy'
 Pool='ayon'
 SecondaryPool='none'
 Group='cache_machines'
 Priority=50
 ChunkSize=999999
.
.
.

For reference, This validator works with Houdini
image

moonyuet
moonyuet previously approved these changes Feb 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@moonyuet moonyuet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the code; it works as expected. it is great to add use_published (its label name is Use Published Scene) in AYON settings, similar to other hosts(as I notice there is use_published =True in the settings).
Just some opinion: it would be great to move get_attribute_defs function to the end of the code for readability.
EDIT: I find some settings not aligning with the ayon settings I will update you later

@moonyuet moonyuet dismissed their stale review February 21, 2024 07:12

I have found some errors

@moonyuet moonyuet self-requested a review February 21, 2024 07:16
moonyuet
moonyuet approved these changes Feb 21, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@moonyuet moonyuet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now. (My bad as I switch to wrong branch.)
image

@ynbot ynbot added module: Deadline type: bug Something isn't working labels Feb 21, 2024
iLLiCiTiT
iLLiCiTiT reviewed Mar 11, 2024
View reviewed changes
iLLiCiTiT
iLLiCiTiT reviewed Mar 11, 2024
View reviewed changes
server_addon/deadline/server/settings/publish_plugins.py Outdated
"optional": False,
"active": True,
"priority": 50,
"chunk_size":999999,
Copy link
Copy Markdown
Member

@iLLiCiTiT iLLiCiTiT Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is set to 999999, default on plugin is 1?

Copy link
Copy Markdown
Member

@moonyuet moonyuet Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I made this implementation of the farm cache, it is set to 999999 avoid users to set the chunk size when they have relative huge frame range (although there is a setting for this chunk size)

Copy link
Copy Markdown
Member Author

@MustafaJafar MustafaJafar Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I change it in plugin too.. set it to use 999999 ?

@MustafaJafar MustafaJafar requested a review from iLLiCiTiT March 11, 2024 12:20
@antirotor antirotor merged commit 11e89c1 into develop Mar 19, 2024
@antirotor antirotor deleted the bugfix/OP-7353-make_houdini_submissions_respect_pools_groups branch March 19, 2024 11:42
@MustafaJafar MustafaJafar mentioned this pull request Mar 25, 2024
Merged
@MustafaJafar MustafaJafar mentioned this pull request May 16, 2024
Merged
antirotor pushed a commit that referenced this pull request Jul 2, 2024
@BigRoy
Merge pull request #10 from ynput/enhancement/usd_workflow_implement_…
da1ae21 
…render_targets

Houdini: Support different render targets for usdrender product
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moonyuet moonyuet moonyuet approved these changes

@antirotor antirotor antirotor approved these changes

@iLLiCiTiT iLLiCiTiT Awaiting requested review from iLLiCiTiT

Assignees

@antirotor antirotor

@iLLiCiTiT iLLiCiTiT

Labels

host: Houdini type: bug Something isn't working

Projects

PR reviewing
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@MustafaJafar @antirotor @iLLiCiTiT @moonyuet @ynbot