TrayPublisher: editorial with folder path by jakubjezek001 · Pull Request #5873 · ynput/OpenPype

jakubjezek001 · 2023-11-06T16:48:16Z

Changelog Description

Support for folder path unique identifiers in editorial and particularly in Traypublisher. This allows multiple shots with the same names in different sequences to be accepted during publishing.

Additional info

Since it is based on Hiero | Global: editorial with folder path #5829 branch - this PR is targeted temporarily back to it so we can see lesser changes in files.

Testing notes:

Open Traypublisher and use simple editorial publishing workflow
You will need to docker compose with ynput/ayon:experimental (let me know if you need help with it).
here is example of EDL to use. You can use it with any of yours vide mp4/mov
simple_editorial_setup__ayon_folderPath.zip
ideally you will also need to change Ayon Resolve addon settings in following way.

go to your Project settings and into ayon+settings://traypublisher/editorial_creators/editorial_simple/shot_rename/shot_rename_template?project=<<< YOUR PROJECT NAME>>>
change value of shot renamer to {_shot_} token only.
Then open Traypublisher in the context of the project and ideally /editorial asset and task edit and set Editorial Simple.
Warning!! - since there is a bug fixed in this AYON: Fix TrayPublisher editorial settings #5880, you will need to make sure there is no task and this settings is empty: ayon+settings://traypublisher/editorial_creators/editorial_simple/shot_add_tasks?project=<<< YOUR PROJECT NAME>>>

ynbot · 2023-11-06T16:48:20Z

Task linked: OP-7234 Use folder path as identifier in traypublisher editorial

openpype/hosts/traypublisher/api/editorial.py

openpype/hosts/traypublisher/plugins/create/create_editorial.py

openpype/hosts/traypublisher/plugins/publish/collect_shot_instances.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

#5873 (comment)

with ayon exception for folderPath

hound

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/usr/local/bin/flake8", line 8, in 
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
    self.visit(item)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 381, in generic_visit
    self.visit(value)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

hound

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/usr/local/bin/flake8", line 8, in 
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
    self.visit(item)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 381, in generic_visit
    self.visit(value)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

hound

Some files could not be reviewed due to errors:

Traceback (most recent call last):

Traceback (most recent call last):
  File "/usr/local/bin/flake8", line 8, in 
    sys.exit(main())
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/cli.py", line 18, in main
    app.run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 393, in run
    self._run(argv)
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 381, in _run
    self.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/main/application.py", line 300, in run_checks
    self.file_checker_manager.run()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 331, in run
    self.run_serial()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 315, in run_serial
    checker.run_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 598, in run_checks
    self.run_ast_checks()
  File "/usr/local/lib/python3.8/dist-packages/flake8/checker.py", line 502, in run_ast_checks
    for (line_number, offset, text, check) in runner:
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 56, in run
    parser.visit(self.tree)
  File "/usr/lib/python3.8/ast.py", line 371, in visit
    return visitor(node)
  File "/usr/lib/python3.8/ast.py", line 379, in generic_visit
    self.visit(item)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 39, in visit_ClassDef
    self.capture_issues_visitor('ClassDef', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 33, in capture_issues_visitor
    self.generic_visit(node)
  File "/usr/lib/python3.8/ast.py", line 381, in generic_visit
    self.visit(value)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 36, in visit_Call
    self.capture_issues_visitor('Call', node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checker.py", line 30, in capture_issues_visitor
    issues = checker.run(node)
  File "/usr/local/lib/python3.8/dist-packages/flake8_django/checkers/render.py", line 22, in run
    if isinstance(arg, ast.Call) and arg.func.id == 'locals':
AttributeError: 'Attribute' object has no attribute 'id'

…ial' into enhancement/OP-7234_Use-folder-path-as-identifier-in-traypublisher-editorial

openpype/hosts/traypublisher/plugins/create/create_editorial.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

…ial' into enhancement/OP-7234_Use-folder-path-as-identifier-in-traypublisher-editorial

iLLiCiTiT

Code changes look ok.

mkolar · 2023-11-20T10:53:15Z

Let's merge this and do a final pass in the target branch

traypublisher: folder path implementation

ae536f2

jakubjezek001 changed the base branch from develop to feature/OP-7190_Use-folder-path-as-identifier-in-editorial November 6, 2023 16:48

jakubjezek001 requested a review from iLLiCiTiT November 6, 2023 16:49

jakubjezek001 removed host: Maya host: Houdini host: UE host: Resolve host: Photoshop host: Fusion host: Hiero host: After Effects host: TV Paint host: Flame Autodesk Flame integration host: Substance Painter labels Nov 6, 2023

jakubjezek001 assigned iLLiCiTiT Nov 6, 2023

iLLiCiTiT reviewed Nov 7, 2023

View reviewed changes

openpype/hosts/traypublisher/api/editorial.py Show resolved Hide resolved

iLLiCiTiT reviewed Nov 7, 2023

View reviewed changes

openpype/hosts/traypublisher/plugins/create/create_editorial.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed Nov 7, 2023

View reviewed changes

openpype/hosts/traypublisher/plugins/publish/collect_shot_instances.py Show resolved Hide resolved

jakubjezek001 and others added 3 commits November 7, 2023 13:28

Update openpype/hosts/traypublisher/api/editorial.py

1e819a2

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

traypublisher: editorial better handling hierarchy for folder path

46761a0

traypublisher: editorial ayon attribute only

62af713

#5873 (comment)

jakubjezek001 requested a review from iLLiCiTiT November 7, 2023 12:45

jakubjezek001 added 4 commits November 7, 2023 14:56

improving code

7aa5b09

ayon distributed folder path from create to publish

638c1c6

traypublisher: editorial collector asset to instance

44578b2

with ayon exception for folderPath

traypublisher: label of instances with folder path

e322639

hound bot reviewed Nov 7, 2023

View reviewed changes

jakubjezek001 force-pushed the enhancement/OP-7234_Use-folder-path-as-identifier-in-traypublisher-editorial branch from 73eba7a to e322639 Compare November 8, 2023 09:46

Merge branch 'feature/OP-7190_Use-folder-path-as-identifier-in-editor…

3e4b7e8

…ial' into enhancement/OP-7234_Use-folder-path-as-identifier-in-traypublisher-editorial

jakubjezek001 force-pushed the enhancement/OP-7234_Use-folder-path-as-identifier-in-traypublisher-editorial branch from 69f56ac to 3e4b7e8 Compare November 8, 2023 13:31

iLLiCiTiT reviewed Nov 13, 2023

View reviewed changes

openpype/hosts/traypublisher/plugins/create/create_editorial.py Outdated Show resolved Hide resolved

iLLiCiTiT reviewed Nov 13, 2023

View reviewed changes

openpype/hosts/traypublisher/plugins/create/create_editorial.py Outdated Show resolved Hide resolved

iLLiCiTiT mentioned this pull request Nov 14, 2023

AYON: Use folder path as unique identifier #5817

Merged

18 tasks

jakubjezek001 and others added 4 commits November 15, 2023 10:25

Update openpype/hosts/traypublisher/plugins/create/create_editorial.py

8c9463a

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

Merge branch 'feature/OP-7190_Use-folder-path-as-identifier-in-editor…

1ec0e20

…ial' into enhancement/OP-7234_Use-folder-path-as-identifier-in-traypublisher-editorial

Merge branch 'feature/OP-7190_Use-folder-path-as-identifier-in-editor…

a9ea198

…ial' into enhancement/OP-7234_Use-folder-path-as-identifier-in-traypublisher-editorial

in ayon folderPath should be on creator instance data

c326a8b

jakubjezek001 requested a review from iLLiCiTiT November 15, 2023 10:46

iLLiCiTiT approved these changes Nov 15, 2023

View reviewed changes

iLLiCiTiT merged commit e18e950 into feature/OP-7190_Use-folder-path-as-identifier-in-editorial Nov 20, 2023

iLLiCiTiT deleted the enhancement/OP-7234_Use-folder-path-as-identifier-in-traypublisher-editorial branch November 20, 2023 17:28

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TrayPublisher: editorial with folder path#5873

TrayPublisher: editorial with folder path#5873
iLLiCiTiT merged 13 commits intofeature/OP-7190_Use-folder-path-as-identifier-in-editorialfrom
enhancement/OP-7234_Use-folder-path-as-identifier-in-traypublisher-editorial

jakubjezek001 commented Nov 6, 2023 •

edited

Loading

Uh oh!

ynbot commented Nov 6, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hound bot left a comment

Uh oh!

hound bot left a comment

Uh oh!

hound bot left a comment

Uh oh!

Uh oh!

Uh oh!

iLLiCiTiT left a comment

Uh oh!

mkolar commented Nov 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jakubjezek001 commented Nov 6, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog Description

Additional info

Testing notes:

Uh oh!

ynbot commented Nov 6, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hound bot left a comment

Choose a reason for hiding this comment

Uh oh!

hound bot left a comment

Choose a reason for hiding this comment

Uh oh!

hound bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

iLLiCiTiT left a comment

Choose a reason for hiding this comment

Uh oh!

mkolar commented Nov 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jakubjezek001 commented Nov 6, 2023 •

edited

Loading