Hiero | Global: editorial with folder path by jakubjezek001 · Pull Request #5829 · ynput/OpenPype

jakubjezek001 · 2023-10-27T16:05:53Z

Changelog Description

Support for folder path unique identifier in editorial and particularly in Hiero. This allows multiple shots with the same names in different sequences to be accepted during publishing.

Additional info

Based on #5817 and expands it towards Editorial publishing.

Testing notes:

start with this step
follow this step

…nto feature/OP-7190_Use-folder-path-as-identifier-in-editorial

- some minor typos fixes - modules sorting

- refactor labels

ynbot · 2023-10-27T16:05:58Z

Task linked: OP-7190 Use folder path as identifier in editorial

ynbot · 2023-10-27T16:05:58Z

Task linked: OP-7176 Use folder path as unique identifier

…nto feature/OP-7190_Use-folder-path-as-identifier-in-editorial

openpype/hosts/hiero/api/plugin.py

jakubjezek001 · 2023-10-27T20:25:41Z

Publishing is crashing on openpype\plugins\publish\extract_hierarchy_to_ayon.py

Logging:
line 82:

Hierarchy_context: {"entity_type": "Project", "name": "SyncSketchTesting", "tasks": [], "attributes": {}, "children": [{"entity_type": "Folder", "name": "shots", "children": [{"entity_type": "Sequence", "name": "sq002", "children": [{"inputs": [], "entity_type": "Shot", "comments": [], "name": "/shots/sq002/sh010", "children": [], "tasks": [{"type": "Compositing", "name": "comp"}], "attributes": {"handleStart": 0, "handleEnd": 8, "frameStart": 1001, "frameEnd": 1051, "clipIn": 76, "clipOut": 126, "fps": 23.976024627685547, "resolutionWidth": 1920, "resolutionHeight": 1080, "pixelAspect": 1}}], "tasks": [], "attributes": {}}, {"entity_type": "Sequence", "name": "sq001", "children": [{"inputs": [], "entity_type": "Shot", "comments": [], "name": "/shots/sq001/sh010", "children": [], "tasks": [{"type": "Compositing", "name": "comp"}], "attributes": {"handleStart": 4, "handleEnd": 4, "frameStart": 1001, "frameEnd": 1052, "clipIn": 24, "clipOut": 75, "fps": 23.976024627685547, "resolutionWidth": 1920, "resolutionHeight": 1080, "pixelAspect": 1}}], "tasks": [], "attributes": {}}], "tasks": [], "attributes": {}}]}

line 65:

Traceback: 
Traceback (most recent call last):
  File "C:\Users\jakubjezek001\AppData\Local\Ynput\AYON\dependency_packages\ayon_2308181924_windows.zip\dependencies\pyblish\plugin.py", line 527, in __explicit_process
    runner(*args)
  File "C:\CODE\__PYPE\ayon-openpype\openpype\plugins\publish\extract_hierarchy_to_ayon.py", line 40, in process
  File "C:\CODE\__PYPE\ayon-openpype\openpype\plugins\publish\extract_hierarchy_to_ayon.py", line 65, in _fill_instance_entities
KeyError: '/shots/sq001/sh010'

Following is set of instances I am publishing:

jakubjezek001 · 2023-10-27T20:32:56Z

Here is also strange thing happening on server. Althought the publishing was not successfull from my previous post here following was created on server. But as you can see the name of folder is now path and not simply sh010

jakubjezek001 · 2023-10-27T20:53:38Z

issue with hierarchy from comments #5829 (comment) and #5829 (comment)
fixed via d9a35e7

openpype/hosts/hiero/api/plugin.py

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

…nto feature/OP-7190_Use-folder-path-as-identifier-in-editorial

antirotor

didn't tested, otherwise it looks good

antirotor · 2023-11-08T10:20:20Z

openpype/hosts/hiero/api/plugin.py

-        self._convert_to_tag_data()
+        tag_hierarchy_data = self._convert_to_tag_data()
+
+        self.tag_data.update(tag_hierarchy_data)


just a naive note about self.tag_data - since it is updated with the content of tag_hierarchy_data, shouldn't it be used late on instead of it? Also, this whole method is returning tag_hierarchy_data but the instance property tag_data already has all of it but is different?

…nto feature/OP-7190_Use-folder-path-as-identifier-in-editorial

openpype/hosts/hiero/plugins/publish/precollect_instances.py

…nto feature/OP-7190_Use-folder-path-as-identifier-in-editorial

iLLiCiTiT

One suggestion, otherwise code looks ok. But I don't know how to test.

mkolar · 2023-11-20T10:53:10Z

Let's merge this and do a final pass in the target branch

jakubjezek001 added 3 commits October 27, 2023 15:30

Merge branch 'feature/OP-7176_Use-folder-path-as-unique-identifier' i…

fc2f393

…nto feature/OP-7190_Use-folder-path-as-identifier-in-editorial

hiero: adding folderPath to creator

4bde7b7

- some minor typos fixes - modules sorting

Hiero: adding asset_name and processing folderPath

4e9173f

- refactor labels

ynbot added type: feature Larger, user affecting changes and completely new things size/XXL Denotes a PR changes 2500+ lines, ignoring general files host: 3dsmax Autodesk 3dsmax host: Hiero host: Houdini host: Nuke host: UE module: Deadline AWS Deadline related features labels Oct 27, 2023

Merge branch 'feature/OP-7176_Use-folder-path-as-unique-identifier' i…

736a2bb

…nto feature/OP-7190_Use-folder-path-as-identifier-in-editorial

jakubjezek001 requested review from antirotor and iLLiCiTiT October 27, 2023 16:10

jakubjezek001 assigned iLLiCiTiT Oct 27, 2023

ynbot removed host: Houdini host: 3dsmax Autodesk 3dsmax host: UE host: Nuke module: Deadline AWS Deadline related features labels Oct 27, 2023

jakubjezek001 removed the size/XXL Denotes a PR changes 2500+ lines, ignoring general files label Oct 27, 2023

iLLiCiTiT reviewed Oct 27, 2023

View reviewed changes

openpype/hosts/hiero/api/plugin.py Show resolved Hide resolved

ynput deleted a comment from ynbot Oct 27, 2023

jakubjezek001 added 2 commits October 27, 2023 22:51

fixing extract hierarchy to ayon

d9a35e7

hound

dcf5855

jakubjezek001 requested a review from iLLiCiTiT October 27, 2023 20:53

ynput deleted a comment from ynbot Oct 27, 2023

iLLiCiTiT reviewed Oct 30, 2023

View reviewed changes

openpype/hosts/hiero/api/plugin.py Outdated Show resolved Hide resolved

Update openpype/hosts/hiero/api/plugin.py

0550668

Co-authored-by: Jakub Trllo <43494761+iLLiCiTiT@users.noreply.github.com>

jakubjezek001 requested a review from iLLiCiTiT October 30, 2023 09:24

iLLiCiTiT mentioned this pull request Oct 30, 2023

AYON: Use folder path as unique identifier #5817

Merged

18 tasks

jakubjezek001 mentioned this pull request Nov 6, 2023

TrayPublisher: editorial with folder path #5873

Merged

Merge branch 'feature/OP-7176_Use-folder-path-as-unique-identifier' i…

bd46c9e

…nto feature/OP-7190_Use-folder-path-as-identifier-in-editorial

antirotor approved these changes Nov 8, 2023

View reviewed changes

Merge branch 'feature/OP-7176_Use-folder-path-as-unique-identifier' i…

db8e8b1

…nto feature/OP-7190_Use-folder-path-as-identifier-in-editorial

jakubjezek001 mentioned this pull request Nov 9, 2023

AYON | Resolve: support for folder path #5892

Merged

iLLiCiTiT reviewed Nov 14, 2023

View reviewed changes

openpype/hosts/hiero/plugins/publish/precollect_instances.py Outdated Show resolved Hide resolved

jakubjezek001 added 2 commits November 15, 2023 11:33

Merge branch 'feature/OP-7176_Use-folder-path-as-unique-identifier' i…

c1dfb05

…nto feature/OP-7190_Use-folder-path-as-identifier-in-editorial

Merge branch 'feature/OP-7176_Use-folder-path-as-unique-identifier' i…

48e00ef

…nto feature/OP-7190_Use-folder-path-as-identifier-in-editorial

iLLiCiTiT approved these changes Nov 15, 2023

View reviewed changes

simplify expression

898f728

iLLiCiTiT merged commit 477bc61 into feature/OP-7176_Use-folder-path-as-unique-identifier Nov 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hiero | Global: editorial with folder path#5829

Hiero | Global: editorial with folder path#5829
iLLiCiTiT merged 12 commits intofeature/OP-7176_Use-folder-path-as-unique-identifierfrom
feature/OP-7190_Use-folder-path-as-identifier-in-editorial

jakubjezek001 commented Oct 27, 2023

Uh oh!

ynbot commented Oct 27, 2023

Uh oh!

ynbot commented Oct 27, 2023

Uh oh!

Uh oh!

jakubjezek001 commented Oct 27, 2023 •

edited

Loading

Uh oh!

jakubjezek001 commented Oct 27, 2023

Uh oh!

jakubjezek001 commented Oct 27, 2023

Uh oh!

Uh oh!

antirotor left a comment

Uh oh!

antirotor Nov 8, 2023

Uh oh!

Uh oh!

iLLiCiTiT left a comment

Uh oh!

mkolar commented Nov 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

jakubjezek001 commented Oct 27, 2023

Changelog Description

Additional info

Testing notes:

Uh oh!

ynbot commented Oct 27, 2023

Uh oh!

ynbot commented Oct 27, 2023

Uh oh!

Uh oh!

jakubjezek001 commented Oct 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jakubjezek001 commented Oct 27, 2023

Uh oh!

jakubjezek001 commented Oct 27, 2023

Uh oh!

Uh oh!

antirotor left a comment

Choose a reason for hiding this comment

Uh oh!

antirotor Nov 8, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

iLLiCiTiT left a comment

Choose a reason for hiding this comment

Uh oh!

mkolar commented Nov 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jakubjezek001 commented Oct 27, 2023 •

edited

Loading