Skip to content

Fix #20247: Support for variadic console controller action methods#20247

Merged
samdark merged 3 commits into
yiisoft:masterfrom
brandonkelly:feature/variadic-params
Aug 19, 2024
Merged

Fix #20247: Support for variadic console controller action methods#20247
samdark merged 3 commits into
yiisoft:masterfrom
brandonkelly:feature/variadic-params

Conversation

@brandonkelly

Copy link
Copy Markdown
Contributor

Adds support for variadic console controller action methods.

public function actionMerge(string ...$names)
{
    // ...
}
php yii foo/bar/merge name1 name2 name3
Q A
Is bugfix?
New feature? ✔️
Breaks BC?

@codecov

codecov Bot commented Aug 17, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 64.94%. Comparing base (34d2396) to head (e45c6a4).
Report is 1 commits behind head on master.

Files Patch % Lines
framework/console/Controller.php 86.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #20247   +/-   ##
=========================================
  Coverage     64.94%   64.94%           
- Complexity    11390    11394    +4     
=========================================
  Files           430      430           
  Lines         36912    36920    +8     
=========================================
+ Hits          23972    23979    +7     
- Misses        12940    12941    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@samdark samdark added this to the 2.0.52 milestone Aug 18, 2024

@samdark samdark left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Please add a line for CHANGELOG. Thanks.

[ci skip]
@brandonkelly

Copy link
Copy Markdown
Contributor Author

@samdark Done

@samdark samdark changed the title Add support for variadic CLI actions Fix #20247: Support for variadic console controller action methods Aug 19, 2024
@samdark samdark merged commit 5abe83e into yiisoft:master Aug 19, 2024
@samdark

samdark commented Aug 19, 2024

Copy link
Copy Markdown
Member

Thank you!

@brandonkelly brandonkelly deleted the feature/variadic-params branch August 21, 2024 17:04
terabytesoftw pushed a commit to terabytesoftw/yii2 that referenced this pull request Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants