Removing and fixing imports and other warnings#1877
Merged
parsonsmatt merged 24 commits intoyesodweb:masterfrom Jun 17, 2025
Merged
Removing and fixing imports and other warnings#1877parsonsmatt merged 24 commits intoyesodweb:masterfrom
parsonsmatt merged 24 commits intoyesodweb:masterfrom
Conversation
Mostly found all the imports of 'Data.Monoid' and 'Data.Semigroup' and removed as much as I can without breaking it. Used CPP for backwards compatibility where needed. Thought about using CPP to avoid deprecation warning of 'parseMonad', but defining a helper function seemed way more straightforward.
…emove the imports)
Mostly found all the imports of 'Data.Monoid' and 'Data.Semigroup' and removed as much as I can without breaking it. Used CPP for backwards compatibility where needed. Thought about using CPP to avoid deprecation warning of 'parseMonad', but defining a helper function seemed way more straightforward.
- removed useless imports - tried to avoid incomplete-uni-patterns with explicit 'error' calls for better error messages - suppress warnings in tests - add 'TypeOperator' pragma for type equality (~) usage - few other things
…ances of 'FormResult' and 'AForm', while staying compatible with 'base >= 4.10'
Vlix
commented
Jun 16, 2025
| {-# LANGUAGE TemplateHaskell #-} | ||
| {-# LANGUAGE TypeFamilies #-} | ||
|
|
||
| import Yesod.Core |
Contributor
Author
There was a problem hiding this comment.
Was removed erroneously in the first batch of pragma orderings
JBetz
pushed a commit
to JBetz/yesod
that referenced
this pull request
Oct 13, 2025
* lots of CPP and cleanup of 'Data.Monoid/Semigroup' stuff Mostly found all the imports of 'Data.Monoid' and 'Data.Semigroup' and removed as much as I can without breaking it. Used CPP for backwards compatibility where needed. Thought about using CPP to avoid deprecation warning of 'parseMonad', but defining a helper function seemed way more straightforward. * yesod-core: found a better solution with 'defaultRequest' * removed a bunch of pragmas that weren't used * removal of Semigroup stuff outside of libraries * bump to 'base >= 4.11' on libraries that had Semigroup imports (and remove the imports) * lots of CPP and cleanup of 'Data.Monoid/Semigroup' stuff Mostly found all the imports of 'Data.Monoid' and 'Data.Semigroup' and removed as much as I can without breaking it. Used CPP for backwards compatibility where needed. Thought about using CPP to avoid deprecation warning of 'parseMonad', but defining a helper function seemed way more straightforward. * yesod-bin: got rid of other warnings * yesod-core: remove warnings - removed useless imports - tried to avoid incomplete-uni-patterns with explicit 'error' calls for better error messages - suppress warnings in tests - add 'TypeOperator' pragma for type equality (~) usage - few other things * yesod-persistent: added 'TypeOperators' pragma and shuffled CPP to be more obvious * yesod-form: added 'TypeOperators' pragma and simplified 'Monoid' instances of 'FormResult' and 'AForm', while staying compatible with 'base >= 4.10' * removed a few unnecessary 'Control.Applicative' imports * yesod-auth: equivalent refactors without warnings, extra pragmas and less shadowing * yesod-form-multi: small cleanup * yesod-test: fixed 'Control.Applicative' imports and fixed a uni-pattern warning * yesod-auth*: more 'Control.Applicative' imports removed * yesod-static: lots of import removal and a few better case expressions * yesod: small refactor * removing unused CPP pragmas and unnecessary 'MIN_VERSION_base(4,11,0)' parts * yesod-auth: accidentally removed a pragma * yesod-bin: removed unused libraries, added space around operator sections * yesod-core: spaces around operator sections, use 'ifndef' instead of 'if !' in CPP * yesod-form/-auth: add spaces around operators * yesod-test: add spaces around operators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last part of #1862
-Woperator-whitespace)