Update yesod-auth and yesod-persistent to persistent-2.9#1516
Update yesod-auth and yesod-persistent to persistent-2.9#1516snoyberg merged 3 commits intoyesodweb:masterfrom
Conversation
|
It would be better to use CPP to support both the old and new version of persistent. And I'd recommend a minor version bump. |
yesod-auth/yesod-auth.cabal
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: yesod-auth | |||
| version: 1.6.3 | |||
| version: 1.7.0 | |||
There was a problem hiding this comment.
According to PVP rules, this is a major version bump. A minor version bump would be 1.6.4.
There was a problem hiding this comment.
Ah I see. I was thinking about it in terms of semantic versioning. That explains my confusion.
yesod-form/yesod-form.cabal
Outdated
| build-depends: base >= 4 && < 5 | ||
| , yesod-core >= 1.6 && < 1.7 | ||
| , yesod-persistent >= 1.6 && < 1.7 | ||
| , yesod-persistent >= 1.7 && < 1.8 |
There was a problem hiding this comment.
Is there a reason that the version bump is needed for yesod-form?
| @@ -1,5 +1,5 @@ | |||
| name: yesod-persistent | |||
| version: 1.6.0 | |||
| version: 1.7.0 | |||
37e9c9e to
4641fa0
Compare
|
@snoyberg I believe I've addressed your feedback. |
|
Although obviously the persistent one needs merging and releasing before this one has value. |
|
Thanks. Sorry, just one more request: could you add a ChangeLog entry to each package that has changed explaining the support for persistent 2.9? |
|
@snoyberg done. Thanks as always for your hard work! |
snoyberg
left a comment
There was a problem hiding this comment.
LGTM. Should I wait to merge when persistent 2.9 is released?
|
I don't think it's strictly necessary to wait, but I don't think the persistent PR has been reviewed at all yet. So... if there are any requested interface changes there it might be problematic. |
|
In that case, I'd say let's hold off for now. Would you mind pinging this issue when the 2.9 release happens? |
This is an accompanying PR to fix changes from yesodweb/persistent#812
Could use advice on the following, not sure whether to bump the patch version or the minor version.