Skip to content

Add support for SQL isolation levels#812

Merged
bitemyapp merged 7 commits intoyesodweb:masterfrom
iand675:master
Jun 19, 2018
Merged

Add support for SQL isolation levels#812
bitemyapp merged 7 commits intoyesodweb:masterfrom
iand675:master

Conversation

@iand675
Copy link
Copy Markdown
Contributor

@iand675 iand675 commented Jun 1, 2018 •
edited
Loading

This adds support for assorted SQL isolation levels to all of the standard SQL backends.

There is a slight breaking change for any dependent SQL backends in that the connBegin function now takes an optional isolation level argument. This is necessary because for MySQL the transaction isolation level must be specified before calling begin.

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@iand675 iand675 mentioned this pull request Jun 4, 2018
Merged
1 task
@paul-rouse
Copy link
Copy Markdown
Contributor

paul-rouse commented Jun 13, 2018

I don't feel very competent to approve this, especially for postgresql which I haven't used for years, but, that said, I've looked through the changes and they seem to be fine. If nobody else steps in with comments, I'll go ahead in a few days.

@iand675
Copy link
Copy Markdown
Contributor Author

iand675 commented Jun 19, 2018

Hi @paul-rouse, any chance you're ready to merge this yet?

@bitemyapp
Copy link
Copy Markdown
Contributor

bitemyapp commented Jun 19, 2018

I'll take a look at this as I'm an active Persistent + PostgreSQL user.

@paul-rouse
Copy link
Copy Markdown
Contributor

paul-rouse commented Jun 19, 2018

Thanks @bitemyapp !

@bitemyapp
Copy link
Copy Markdown
Contributor

bitemyapp commented Jun 19, 2018

This is a very neat PR. Thank you @iand675, good seeing you around too :)

@bitemyapp bitemyapp merged commit 53fa758 into yesodweb:master Jun 19, 2018
@iand675
Copy link
Copy Markdown
Contributor Author

iand675 commented Jun 27, 2018

@bitemyapp Glad to you like it! Any notion on when it'll go up on hackage? Waiting to merge the corresponding yesod PRs til this is all the way shipped.

@bitemyapp
Copy link
Copy Markdown
Contributor

bitemyapp commented Jun 27, 2018

@iand675 I'll take a sweep of open PRs this weekend, see what can make it in.

naushadh added a commit to naushadh/persistent that referenced this pull request Jul 4, 2018
@naushadh
Port yesodweb#812 from persistent-mysql: Add support for SQL isolat…
2c6ea59 
…ion levels.
@ProofOfKeags
Copy link
Copy Markdown

ProofOfKeags commented Aug 24, 2018

Quickly wanted to check in and see if this can go to hackage/stackage. Otherwise would you recommend pinning this hash?

@bitemyapp bitemyapp mentioned this pull request Aug 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@iand675 @paul-rouse @bitemyapp @ProofOfKeags