Added assertEq, deprecated assertEqual#1259
Merged
snoyberg merged 1 commit intoyesodweb:masterfrom Aug 10, 2016
bitemyapp:add-pretty-assert
Merged
Added assertEq, deprecated assertEqual#1259snoyberg merged 1 commit intoyesodweb:masterfrom bitemyapp:add-pretty-assert
snoyberg merged 1 commit intoyesodweb:masterfrom
bitemyapp:add-pretty-assert
Conversation
yesod-test/Yesod/Test.hs
Outdated
| "First argument: " ++ ppShow a ++ "\n" ++ | ||
| "Second argument: " ++ ppShow b ++ "\n" | ||
|
|
||
| {-# DEPRECATED assertEqual "Use assertEqual instead" #-} |
Member
There was a problem hiding this comment.
Did you mean Use assertEq instead?
Contributor
Author
There was a problem hiding this comment.
@snoyberg quite right! Forgot to amend it after I figured out the name.
use assertEq instead
| extra-source-files: README.md, LICENSE, test/main.hs, ChangeLog.md | ||
|
|
||
| library | ||
| build-depends: base >= 4.3 && < 5 |
Member
There was a problem hiding this comment.
Were the edits to this file intentional?
Contributor
Author
There was a problem hiding this comment.
@snoyberg yes, my eyes swam checking for something, so I fired my re-ordering function on it. I can remove it if you like.
Member
There was a problem hiding this comment.
Generally I keep such changes separate, but not a big deal. I'll merge once Travis goes green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1255