Better error provenance for stuff invoking withResponse'#1191
Merged
snoyberg merged 4 commits intoyesodweb:masterfrom Mar 21, 2016
bitemyapp:master
Merged
Better error provenance for stuff invoking withResponse'#1191snoyberg merged 4 commits intoyesodweb:masterfrom bitemyapp:master
snoyberg merged 4 commits intoyesodweb:masterfrom
bitemyapp:master
Conversation
|
👍 Seems like an improvement to me. |
Contributor
Author
|
The test failure seems spurious, could be wrong. |
yesod-test/yesod-test.cabal
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: yesod-test | |||
| version: 1.5.0.1 | |||
| version: 1.6.0.0 | |||
Member
There was a problem hiding this comment.
What's the reason for the major version bump? It looks like this only changes internal functions.
Contributor
Author
There was a problem hiding this comment.
Oh so it does. I'd managed that on accident, thinking I'd changed the type signature of something that was exported. Nuts. I'll fix it, sorry!
snoyberg
added a commit
that referenced
this pull request
Mar 21, 2016
Better error provenance for stuff invoking withResponse'
Member
|
Thanks Chris! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to take a light touch, mostly mucking with the prime variants of functions.
Here's how it looks:
This is intended to resolve #1185