Skip to content

Add functions to yesod-test to support the new CSRF middleware#1058

Merged
gregwebs merged 1 commit intoyesodweb:masterfrom
MaxGabriel:csrfMiddlewareYesodTest
Aug 21, 2015
Merged

Add functions to yesod-test to support the new CSRF middleware#1058
gregwebs merged 1 commit intoyesodweb:masterfrom
MaxGabriel:csrfMiddlewareYesodTest

Conversation

@MaxGabriel
Copy link
Copy Markdown
Member

This PR adds functions to add CSRF tokens from cookies, supporting the new CSRF middleware added in #1017.

@MaxGabriel
Copy link
Copy Markdown
Member Author

@snoyberg or @gregwebs Can you upload yesod-core-1.4.14 to Hackage so that yesod-test can depend on it?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know the best spot for this function, either in the export list or in the source code.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine to me

@snoyberg
Copy link
Copy Markdown
Member

Uploaded

@MaxGabriel MaxGabriel force-pushed the csrfMiddlewareYesodTest branch from d2b992f to 374195b Compare August 20, 2015 05:18
@gregwebs
Copy link
Copy Markdown
Member

Thanks for handling this issue from every angle :) Testing is often forgotten about

gregwebs added a commit that referenced this pull request Aug 21, 2015
Add functions to yesod-test to support the new CSRF middleware
@gregwebs gregwebs merged commit 6d15e7c into yesodweb:master Aug 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants