wai-handler-launch: Improvements to ping's javascript script.#494
Merged
snoyberg merged 1 commit intoyesodweb:masterfrom Jan 22, 2017
Merged
Conversation
- Avoid using the browser's cache for the response. IE returns the response from cache and does not send the ping request to the server causing the server to shut down. - Make the javascript use the asynchronous ajax request instead of synchronous. This fixes the warning 'Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/.' displayed in the Chrome browser.
Member
|
Sorry for the delay on this, it slipped through the cracks somehow. Thank you! |
snoyberg
added a commit
that referenced
this pull request
Feb 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the ping request uses GET method, IE returns the response from
cache and does not send the ping request to the server causing the server
to shut down.
synchronous request.
This fixes the warning displayed in Chrome:
Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check http://xhr.spec.whatwg.org/.