Skip to content

Providing NoManager#1017

Merged
kazu-yamamoto merged 1 commit intoyesodweb:masterfrom
kazu-yamamoto:no-time-manager
Dec 18, 2024
Merged

Providing NoManager#1017
kazu-yamamoto merged 1 commit intoyesodweb:masterfrom
kazu-yamamoto:no-time-manager

Conversation

@kazu-yamamoto
Copy link
Copy Markdown
Contributor

"initialize" with non positive integer creates "NoManager".

@edsko What do you think?

@edsko
Copy link
Copy Markdown
Contributor

edsko commented Dec 17, 2024

I'll give this a shot and let you know :)

edsko added a commit to well-typed/grapesy that referenced this pull request Dec 17, 2024
edsko added a commit to well-typed/grapesy that referenced this pull request Dec 17, 2024
@edsko
Copy link
Copy Markdown
Contributor

edsko commented Dec 17, 2024

@kazu-yamamoto Looks good to me, and I ran the grapesy test-suite with this, using 0 instead of the previous workaround of maxBound, and it seems to be working perfectly (tested memory behaviour too, just in case). Thanks!

"initialize" with non positive integer creates "NoManager".
@kazu-yamamoto kazu-yamamoto merged commit 09d4e41 into yesodweb:master Dec 18, 2024
@kazu-yamamoto kazu-yamamoto deleted the no-time-manager branch December 18, 2024 04:17
@kazu-yamamoto
Copy link
Copy Markdown
Contributor Author

Thanks.
A new version has been released.

edsko added a commit to well-typed/grapesy that referenced this pull request Dec 18, 2024
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Jan 30, 2025
## 0.2.2

* `initialize` with non positive integer creates a time manager
  which does not maintain timeout.
  [#1017](yesodweb/wai#1017)

## 0.2.1

* Export KilledByThreadManager exception
  [#1016](yesodweb/wai#1016)

## 0.2.0

* Providing `System.ThreadManager`.
* `withHandle` catches `TimeoutThread` internally.
  It returns `Nothing` on timeout.

## 0.1.3

* Providing `withHandle` and `withHandleKillThread`.

## 0.1.2

* Holding `Weak ThreadId` to prevent thread leak again
  [#1013](yesodweb/wai#1013)

## 0.1.1

* Removing `unliftio`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants