Merged
Conversation
ad208f1 to
4abdd80
Compare
kazu-yamamoto
approved these changes
Nov 6, 2024
Contributor
kazu-yamamoto
left a comment
There was a problem hiding this comment.
I agree with this change.
Since this PR includes CI stuff, @Vlix should merge this PR by himself, I think.
a73fee9 to
ac5cf08
Compare
Contributor
Author
|
Released new minor version for |
Contributor
|
I have released @Vlix You should push the tag for |
Contributor
Author
|
@kazu-yamamoto I did do that, didn't I? Or do you mean the 3.1.16 tag? (seems I forgot that one) EDIT: also pushed that one |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 30, 2025
## 3.1.17 * Started deprecation of `data-default` [#1011](yesodweb/wai#1011) * All `Default` instances have comments that these will be removed in a future major version. * `def` exported from `Network.Wai.Middleware.Gzip` now has a deprecation warning * All uses of `def` have been replaced with explicit `default{TYPE_NAME}` values. * Some additional documentation ## 3.1.16 * Substituted `data-default-class` for `data-default` [#1010](yesodweb/wai#1010)
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Feb 1, 2025
## 3.4.12 * Rethrowing asynchronous exceptions [#1013](yesodweb/wai#1013) ## 3.4.11 * Removing `unliftio`. ## 3.4.10 * Removed `data-default` dependency entirely. Does now require `>= tls-2.1.3`. [#1011](yesodweb/wai#1011) ## 3.4.9 * Using `timeout` for `handshake` to prevent thread leaks. ## 3.4.8 * Substituted `data-default-class` for `data-default` [#1010](yesodweb/wai#1010) ## 3.4.7 * Expose `attachConn` to use post-handshake TLS connection. [#1007](yesodweb/wai#1007) ## 3.4.6 * Preparing for tls v2.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting your PR, check that you've:
@sincedeclarations to the HaddockAfter submitting your PR:
So I really want to get rid of any
data-default, and now withtls-2.1.3we can at least get rid of the dependency onwarp-tls. Though it requirestls >= 2.1.3, which will be a bit more restrictive, though I don't think many people will have problems because of this.I've also tried my best to obviously deprecate the
Defaultinstances that are still in this repo. I've made a synonym fordefaultGzipSettings, sincedefwas also directly (re-)exported, so now we can give an actual Deprecation warning. Though we can't on the other instances... unfortunately.I'm hoping come
wai-extra-3.3these instances can be removed as well.