Fix for aeson-2#260
Merged
snoyberg merged 5 commits intoyesodweb:masterfrom Nov 17, 2021
brandon-leapyear:chinn/aeson-2
Merged
Conversation
snoyberg
requested changes
Nov 16, 2021
.github/workflows/tests.yml
Outdated
| includes: | ||
| - os: ubuntu-latest | ||
| resolver: nightly | ||
| extra_args: --stack-yaml=stack-ghc-9.2.yaml |
Member
There was a problem hiding this comment.
Actually, on closer inspection, it looks like the builds are reporting using this for all builds now. I'd recommend unifying this with resolver as something like:
resolver:
- --resolver nightly
- --resolver lts-18
- ...
- --stack-yaml=stack-ghc-9.2.yaml
Contributor
Author
There was a problem hiding this comment.
Sorry, can you try it again? I used includes instead of include 🤦
Contributor
Author
There was a problem hiding this comment.
Weird... I'm not sure why it's not working. But i'll change it anyway
Member
|
Thanks! |
snoyberg
added a commit
that referenced
this pull request
Nov 17, 2021
This was referenced Nov 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ This is an old work account. Please reference @brandonchinn178 for all future communication ✨
Resolves #258
Not sure how to / if I should add aeson-2 to the CI matrix, but it builds locally